feat: add the ability to execute status actions when the proposal status is updated manually - #1441

Merged

jekabs-karklins merged 206 commits into

SWAP-5434-as-a-user-officer-i-want-to-specify-which-actions

Jul 3, 2026

Commits on Dec 22, 2025

feat: add new workflow data structures and update related data sources
jekabskarklins
committed
feat: rename and refactor status changing events handling in workflow connections
jekabskarklins
committed
fix: throw error when status changing event is not found in database
jekabskarklins
committed
feat: overhaul workflow status handling by renaming and refactoring related methods and types
jekabskarklins
committed

Commits on Dec 24, 2025

feat: overhaul workflow data structures and connections by refactoring and introducing WorkflowStatus model
jekabskarklins
committed

Commits on Dec 29, 2025

feat: update WorkflowStatus model and related components to use workflowStatusId instead of id
jekabskarklins
committed
fix: comment out validation schema for deleteWorkflowStatus and add TODO for update
jekabskarklins
committed
feat: refactor workflow connection handling by renaming methods and introducing CreateWorkflowConnection mutation
jekabskarklins
committed
feat: update WorkflowEditor to use workflowStatusId for source and target status lookups
jekabskarklins
committed
feat: add ON DELETE CASCADE to foreign key constraints in workflow_status_connections
jekabskarklins
committed
fix: update edge identification logic to use connection ID directly
jekabskarklins
committed
feat: overhaul workflow data structures by removing status changing events table and updating related references
jekabskarklins
committed

Commits on Dec 30, 2025

feat: rename and update connection status actions mutation to setStatusActionsOnConnection
jekabskarklins
committed
refactor: update workflow connection action identifiers to use new naming conventions
jekabskarklins
committed
feat: add ON DELETE CASCADE to foreign key constraints in workflow data structures
jekabskarklins
committed
feat: add xstate for workflow state management and implement getWorkflowStructure method
jekabskarklins
committed

Commits on Dec 31, 2025

feat: enhance workflow management by adding workflow status handling and guards
jekabskarklins
committed
refactor: rename updateProposalStatus to updateProposalWfStatus for consistency in workflow management
jekabskarklins
committed
feat: overhaul workflow guards by implementing IGuard interface and refactoring IsProposalSubmittedGuard
jekabskarklins
committed
feat: enhance workflow management by adding default workflow status handling and refactoring related methods
jekabskarklins
committed

Commits on Jan 1, 2026

refactor: remove unused getProposalWorkflowByCallId function and log error for missing proposal workflow
jekabskarklins
committed
feat: overhaul workflow management by replacing IGuard interface with GuardFn and refactoring related guards
jekabskarklins
committed
refactor: remove guardNames from WorkflowDataSource and related mock implementations
jekabskarklins
committed
feat: implement workflow machine and guards with refactored state management
jekabskarklins
committed

Commits on Jan 2, 2026

Commits on Jan 6, 2026

refactor: remove unused ProposalEventsRecord interface and clean up workflow migration scripts
jekabskarklins
committed
Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabskarklins
committed
fix: update join table in CallDataSource to use workflow_has_statuses for proposal status filtering
jekabskarklins
committed
fix: update edge style logic in WorkflowEdge component for better visual representation
jekabskarklins
committed
fix: adjust edge style in WorkflowEdge component for improved visibility
jekabskarklins
committed

Commits on Jan 7, 2026

feat: implement ProposalWorkflowEngine and integrate into dependency configurations
jekabskarklins
committed

Commits on Jan 9, 2026

Add guards for proposal workflow validation
jekabskarklins
committed

Commits on Jan 13, 2026

Refactor status handling in experiments and proposals
jekabskarklins
committed

Commits on Jan 14, 2026

refactor: remove shortCode from Status and related data sources
jekabskarklins
committed
refactor: replace shortCode with id in status-related data structures and mutations
jekabskarklins
committed

Commits on Jan 15, 2026

refactor: update workflow and status handling to use 'id' instead of 'shortCode'
jekabskarklins
committed
Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabskarklins
committed
refactor: update WorkflowEdge and StatusNode to use 'id' instead of 'shortCode'
jekabskarklins
committed
feat: add sourceHandle and targetHandle to workflow connections and related structures
jekabskarklins
committed
fix: update status_id to use draftWfStatus for accurate workflow status handling
jekabskarklins
committed
fix: update workflow handling to use 'id' instead of 'shortCode' for status and connection nodes
jekabskarklins
committed

Commits on Jan 16, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabskarklins
committed
feat: integrate confirmation dialog for status deletion in StatusNode component
jekabskarklins
committed

Commits on Jan 21, 2026

fix: update status handling to replace 'shortCode' with 'statusId' in StatusDataSource and related components
jekabskarklins
committed

Commits on Jan 22, 2026

refactor: overhaul workflow handling by replacing StatusDataSource with WorkflowDataSource across multiple components
jekabskarklins
committed
Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabskarklins
committed

Commits on Jan 26, 2026

Refactor workflow status handling in Cypress tests
jekabskarklins
committed
refactor: update validation schemas in StatusMutations and WorkflowMutations
jekabskarklins
committed

Commits on Jan 27, 2026

refactor: enhance event handling by adding guards for proposal and call events
jekabskarklins
committed
refactor: update proposal and status handling by renaming fields and removing unused properties
jekabskarklins
committed
refactor: update status filter values to use descriptive strings instead of numeric IDs
jekabskarklins
committed
refactor: update EdgeData interface to use status IDs instead of short codes
jekabskarklins
committed
refactor: update duo-validation package to version 6.0.0 in frontend and backend
jekabskarklins
committed

Commits on Jan 28, 2026

refactor: overhaul workflow management by enhancing status handling, adding workflow view, and improving UI components
jekabskarklins
committed

Commits on Jan 29, 2026

refactor: update workflow status handling in FAPs tests to use dynamic status IDs
jekabskarklins
committed
refactor: enhance workflow status management in technique proposal tests by adding multiple statuses dynamically
jekabskarklins
committed
refactor: enable technique proposal and advanced tests by removing skip
jekabskarklins
committed
refactor: update proposal status input IDs to use 'selectedWorkflowStatusId' for consistency
jekabskarklins
committed
refactor: update proposal status handling to use 'selectedWorkflowStatusId' and add workflow status to proposals
jekabskarklins
committed
Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabskarklins
committed
refactor: remove 'only' from create Proposal status test to enable execution
jekabskarklins
committed
refactor: add status to workflow in proposal tests for improved coverage
jekabskarklins
committed
refactor: update workflow data structures to link proposals and experiment safety to the new workflow graph
jekabskarklins
committed
refactor: enhance workflow status handling by adding 'Feasibility' status and updating type definitions
jekabskarklins
committed
refactor: add 'Feasibility' status to workflow and integrate into instrument tests
jekabskarklins
committed
refactor: add updated_at column to workflows and enhance workflow structure handling
jekabskarklins
committed
refactor: enhance statusName column rendering with clickable link for status updates
jekabskarklins
committed

Commits on Feb 2, 2026

refactor: overhaul workflow data structures and integrate workflow status handling across experiments and proposals
jekabskarklins
committed

Commits on Feb 3, 2026

refactor: streamline workflow status handling by removing position parameters and using default workflow ID
jekabskarklins
committed
refactor: streamline workflow status handling by removing position parameters and using default workflow ID
jekabskarklins
committed
Merge branch 'SWAP-4949-workflow-overhaul' of github.com:UserOfficeProject/user-office-core into SWAP-4949-workflow-overhaul
jekabskarklins
committed
test: enable proposal allocation time unit test
jekabskarklins
committed
refactor: optimize SQL query for average grade calculation in proposal reviews
jekabskarklins
committed
fix: add ORDER BY clause to proposal_pk in status migration query
jekabskarklins
committed
refactor: remove unused event bus publishing functions and caching logic from workflow machine
jekabskarklins
committed
fix: cleanup
jekabskarklins
committed
fix: update workflow status ID reference in settings tests
jekabskarklins
committed

Commits on Feb 4, 2026

fix: improve error message for connecting statuses from different workflows
jekabskarklins
committed
refactor: streamline proposal status handling in settings tests
jekabskarklins
committed

Commits on Feb 7, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabskarklins
committed

Commits on Feb 8, 2026

refactor: enhance workflow status handling in settings tests
jekabskarklins
committed
feat: add callEnded parameter to updateCall mutation
jekabskarklins
committed
refactor: update workflow status handling and improve notification messages
jekabskarklins
committed
refactor: skip proposal status update test for conditional checks
jekabskarklins
committed
test: enable only the proposal workflow status removal test
jekabskarklins
committed
refactor: update proposalStatusId handling to support 'ALL' filter
jekabskarklins
committed
feat: enhance proposal status update to validate workflow status before change
jekabskarklins
committed
feat: add new workflow statuses for Instrument Scientist Review and update status handling in proposal tests
jekabskarklins
committed
refactor: update workflow status identifiers in tests and components
jekabskarklins
committed
feat: add 'EDITABLE_SUBMITTED_INTERNAL' status to workflow and adjust position
jekabskarklins
committed

Commits on Feb 9, 2026

feat: update workflow statuses for Instrument Scientist Review and adjust status handling in tests
jekabskarklins
committed

Commits on Feb 13, 2026

Commits on Feb 17, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
yoganandaness
authored

Commits on Feb 19, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabs-karklins
authored

Commits on Feb 22, 2026

refactor: simplify createWorkflowConnection parameters for improved readability
jekabskarklins
committed
refactor: update validation schemas to use string for IDs and improve naming consistency
jekabskarklins
committed
refactor: rename variable for initial workflow status in createExperimentSafety method
jekabskarklins
committed
refactor: remove unused StatusDataSourceMock and update proposal mock structure in InstrumentMutations tests
jekabskarklins
committed
refactor: rename newStatus to newWorkflowStatus for clarity in logContext
jekabskarklins
committed
refactor: simplify creation of new proposal workflow connection for improved readability
jekabskarklins
committed
refactor: remove xstate dependency from package.json and package-lock.json
jekabskarklins
committed
refactor: simplify return statement in getStatusEngineReadyProposals method
jekabskarklins
committed
refactor: remove hover scaling effect from StyledHandle for consistency
jekabskarklins
committed

Commits on Feb 24, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabskarklins
committed
refactor: enhance StyledHandle visibility logic based on connection state
jekabskarklins
committed

Commits on Mar 3, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabskarklins
committed

Commits on Mar 16, 2026

Commits on Mar 19, 2026

Merge branch 'develop' of github.com:UserOfficeProject/user-office-core into SWAP-4949-workflow-overhaul
yoganandaness
committed

Commits on Mar 23, 2026

Commits on Mar 24, 2026

fix: show proposal ids
jekabskarklins
committed
fix: clone proposal bug
jekabskarklins
committed

Commits on Mar 26, 2026

refactor: update event handling in ProposalWorkflowEngine and Actor to include transition status
jekabskarklins
committed
fix: correct formatting of warning alert for status change to DRAFT
jekabskarklins
committed
refactor: streamline state transition tests and enhance guard handling
jekabskarklins
committed

Commits on Mar 27, 2026

feat: add workflowConnectionId to change proposals status mutation and UI for running status actions
jekabskarklins
committed

Commits on Mar 31, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabs-karklins
authored

Commits on Apr 1, 2026

Commits on Apr 8, 2026

Commits on Apr 12, 2026

Commits on Apr 20, 2026

Commits on Apr 21, 2026

refactor: remove obsolete triggers and functions related to workflow status management
jekabskarklins
committed
fix: add getStatusByWorkflowStatusId method to StatusDataSource and its implementations
jekabskarklins
committed
fix: remove status_id from proposals
jekabskarklins
committed
fix: fix tests
jekabskarklins
committed

Commits on Apr 22, 2026

fix: fix seeds
jekabskarklins
committed
fix: include reference to proposal_status
jekabskarklins
committed
fix: remove status_id from ExperimentSafety and related data sources
jekabskarklins
committed
fix: skip migration for experiment_safety as it no longer uses status_id
jekabskarklins
committed
fix: simplify logic in UserAuthorization and FapQueries, streamline WorkflowQueries method
jekabskarklins
committed
fix: initialize statusId as an empty string in createExperimentSafetyStub
jekabskarklins
committed

Commits on Apr 27, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
yoganandaness
authored
fix: update guard names
jekabskarklins
committed

Commits on Apr 29, 2026

fix: format code for isEveryFapInstrumentMeetingSubmittedForProposalGuard for improved readability
jekabskarklins
committed
fix: enable test for updating proposal status multiple times if conditions are met
jekabskarklins
committed
fix: rename variables for consistency and clarity in createWorkflowMachine
jekabskarklins
committed
fix: rename workflow status variables for consistency across ProposalMutations, experiment, and proposal files
jekabskarklins
committed
fix: rename draft workflow status variable for consistency in settings tests
jekabskarklins
committed
fix: move status creation to beforeEach for Instruments tests to avoid redundancy
jekabskarklins
committed

Commits on May 2, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabs-karklins
authored

Commits on May 4, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabs-karklins
authored
fix: performance tweak
jekabskarklins
committed
fix: rename workflow status variables for clarity in WorkflowEditor
jekabskarklins
committed
fix: clarify comments regarding workflow status removal in WorkflowEditorModel and usePersistWorkflowEditorModel
jekabskarklins
committed

Commits on May 12, 2026

Merge develop into SWAP-5434-as-a-user-officer-i-want-to-specify-which-actions
jekabskarklins
committed

Commits on May 20, 2026

fix: update imports from simpleStateMachine to stateMachine
jekabskarklins
committed
fix: remove unused reducer middleware from WorkflowEditor and WorkflowView
jekabskarklins
committed
fix: replace hardcoded 'EXPIRED' status with StatusCode.EXPIRED in TechniqueProposalTable
jekabskarklins
committed
fix: rename type StfcRolesToEssRole to StfcRolesToSystemRole for consistency
jekabskarklins
committed
Merge branch 'develop' into SWAP-4949-workflow-overhaul
jekabskarklins
committed
fix: remove unused dummyProposalEvents and update getStatusByWorkflowStatusId logic
jekabskarklins
committed

Commits on May 21, 2026

fix: correct import paths for stateMachine module across guards and related files
jekabskarklins
committed

Commits on May 22, 2026

Merge branch 'develop' into SWAP-4949-workflow-overhaul
bolmsten
authored

Commits on May 27, 2026

Commits on Jun 2, 2026

Merge branch 'develop' into SWAP-5434-as-a-user-officer-i-want-to-specify-which-actions
jekabs-karklins
authored

Commits on Jun 3, 2026

Merge branch 'develop' into SWAP-5434-as-a-user-officer-i-want-to-specify-which-actions
jekabs-karklins
authored

Commits on Jun 10, 2026

Merge branch 'develop' into SWAP-5434-as-a-user-officer-i-want-to-specify-which-actions
jekabskarklins
committed
fix: give more descriptive name for the param
jekabskarklins
committed

Commits on Jun 19, 2026

Merge branch 'develop' into SWAP-5434-as-a-user-officer-i-want-to-specify-which-actions
jekabs-karklins
authored

Commits on Jun 23, 2026

Merge branch 'develop' into SWAP-5434-as-a-user-officer-i-want-to-specify-which-actions
jekabs-karklins
authored

Commits on Jun 25, 2026

Merge branch 'develop' into SWAP-5434-as-a-user-officer-i-want-to-specify-which-actions
jekabskarklins
committed
fix: add events and actions
jekabskarklins
committed

Commits on Jun 29, 2026

Merge branch 'develop' into SWAP-5434-as-a-user-officer-i-want-to-specify-which-actions
jekabs-karklins
authored

Commits on Jul 1, 2026

Commits on Jul 3, 2026