fix: fap review assignment usability improvements - #1482
Merged
TCMeldrum merged 14 commits intoJun 4, 2026
Conversation
TCMeldrum
changed the title
Scott-James-Hurley
requested changes
Apr 21, 2026
Scott-James-Hurley
approved these changes
Apr 29, 2026
Co-authored-by: Copilot <copilot@github.com>
Collaborator
|
usiblity -> usability |
Collaborator
|
And I am wondering what the difference is between a proposalID and a proposalPK? |
Contributor
proposalPK is a surrogate key, while proposalId is the natural key |
TCMeldrum
changed the title
jekabs-karklins
self-requested a review
June 4, 2026 09:05
TCMeldrum
enabled auto-merge (squash)
June 4, 2026 09:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker#1570 Closes UserOfficeProject/issue-tracker#1571
Description
Small changes to unselect a proposal once you have assigned reviewers to it and to show the proposal IDs in the model so users can see which proposal they are assigning.
Motivation and Context
User feedback around the model. Helps them be sure of what proposal they are currently looking at
How Has This Been Tested
Fixes
Changes
Depends on
Tests included/Docs Updated?