feat: a view to show what proposals are assigned to fap reviewers

[TCMeldrum]

Closes UserOfficeProject/issue-tracker#1572

Description

Implemented a new feature to show assigned proposals to FAP reviewers.

Motivation and Context

The change is required to enhance the visibility of assigned proposals to FAP reviewers, which will help streamline review processes and increase efficiency.

Changes

1. Enabled visibility of the Reviewers to Assignments view, allowing users to see which proposals have been assigned to which reviewers.
2. Introduced functionality to assign proposals to reviewers in the Reviewers to Assignments view.
3. Updated the FAP page tab index to reflect the new feature.

How Has This Been Tested?

Fixes Jira Issue

https://jira.ess.eu//browse/

Depends On

Tests included/Docs Updated?

• I have added tests to cover my changes.
• All relevant doc has been updated

[jekabs-karklins]

Question: would that be possible to add some screenshots, I tis quiet hard for me at least to see what has changed. Thank you.

[TCMeldrum]

Have added some screenshots @jekabs-karklins

[jekabs-karklins]

Have added some screenshots @jekabs-karklins

Hi, @TCMeldrum
Did you add them to the PR? I can't seem to locate

[TCMeldrum]

Have added some screenshots @jekabs-karklins

Hi, @TCMeldrum Did you add them to the PR? I can't seem to locate

So sorry I must have forgot to click save 🤦

[Scott-James-Hurley]

I can't find where this property is used; the comment above doesn't seem to match it.

[TCMeldrum]

Assume you are talking about the confirm type. It is used in combo with this function https://github.com/UserOfficeProject/user-office-core/blob/8f0ac02cdc644087c92a499f0fb1d98b1e0225ff/apps/frontend/src/utils/withConfirm.tsx. You wrap the function in this case (FapReviewersAndAssignmentsTable) with withConfirm to add a conformation promt and uses the confirmed prop.

At least i think thats how it works.

[Scott-James-Hurley]

This line is commented out

[Scott-James-Hurley]

• Do FAPs want to keep the old way of assigning reviewers as well?
• When testing locally, I can't seem to sort the table by name
• An idea for the modal that allows you to assign proposals to the selected reviewers, would it be useful to show the number of reviewers currently assigned to each proposal as well? Just a thought.

This looks great - nicely done

[TCMeldrum]

Do FAPs want to keep the old way of assigning reviewers as well?
Yeah I think it would be good to keep both ways

Have added the other 2 comments thanks!

[jekabs-karklins]

Solid work, I tested that with our live database and it also looks good