Skip to content

chore(deps-dev): bump sinon and @types/sinon in /apps/backend - #1498

Merged
github-actions[bot] merged 8 commits into
developfrom
dependabot-npm_and_yarn-apps-backend-multi-b38355ff25
Jun 4, 2026
Merged

chore(deps-dev): bump sinon and @types/sinon in /apps/backend#1498
github-actions[bot] merged 8 commits into
developfrom
dependabot-npm_and_yarn-apps-backend-multi-b38355ff25

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github May 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps sinon and @types/sinon. These dependencies needed to be updated together.
Updates sinon from 17.0.1 to 21.1.2

Changelog

Sourced from sinon's changelog.

21.1.2

  • 53817f7d Upgrade to ESLint 10 and new shared config (#2696) (Carl-Erik Kopseng)
    • Upgrade to ESLint 10 and new shared config
    • Update deps
  • d7a682e0 fix: move npm-run-all to devDeps (#2694) (Avi Vahl)

    used only during dev, and caused a considerable dep count jump downstream

  • 5b8720ec use latest shared eslint-config (Carl-Erik Kopseng)

Released by Carl-Erik Kopseng on 2026-04-11.

21.1.1

  • 3c8b023b Update deps (Carl-Erik Kopseng)
  • 2eabf5da fix(#2692): Remove ESM-only supports-color as it breaks CJS exports (#2693) (Carl-Erik Kopseng)
    • fix(#2692): Remove ESM-only supports-color as it breaks CJS exports

Released by Carl-Erik Kopseng on 2026-04-10.

21.1.0

  • 0a5526c5 updated deps (Carl-Erik Kopseng)
  • 5262204f fix: build artifacts before running bundled tests (Carl-Erik Kopseng)
  • 819bb64b Migration to ECMAScript modules (ESM) (#2683) (Carl-Erik Kopseng)

    This allowed us to finally consume ESM-only dependencies and has broken us free from some CJS shackes. Now produce the same API surface for CJS consumers, as well, by generating ./lib

    • Modern ignores 😁
    • test: add distribution harness
    • test: verify packed cjs and esm entrypoints
    • test: lock distribution api manifest
    • test: smoke test built pkg artifacts
    • docs: require contract tests for package migration
    • test: guard esm migration regressions
    • docs: require contract gate for esm migration
    • build: generate cjs lib from esm source entries
    • refactor: port root api surface to esm
    • build: clean port of root api to esm
    • docs: include implementation plans
    • fix: align lint and smoke tests with esm migration
    • refactor: complete esm port of all core components
    • refactor: finalize esm migration with sandbox and naming fixes
    • fix: finish esm migration stabilization

... (truncated)

Commits

Updates @types/sinon from 9.0.11 to 21.0.1

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot
chore(deps-dev): bump sinon and @types/sinon in /apps/backend
ce2c608 
Bumps [sinon](https://github.com/sinonjs/sinon) and [@types/sinon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/sinon). These dependencies needed to be updated together.

Updates `sinon` from 17.0.1 to 21.1.2
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](sinonjs/sinon@v17.0.1...v21.1.2)

Updates `@types/sinon` from 9.0.11 to 21.0.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/sinon)

---
updated-dependencies:
- dependency-name: sinon
  dependency-version: 21.1.2
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: "@types/sinon"
  dependency-version: 21.0.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels May 2, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner May 2, 2026 10:02
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels May 2, 2026
@dependabot
dependabot Bot requested review from William-Edwards-STFC and removed request for a team May 2, 2026 10:02
@github-actions
github-actions Bot enabled auto-merge May 2, 2026 10:03
@yoganandaness

yoganandaness commented May 29, 2026

Copy link
Copy Markdown
Contributor

@copilot make sure all the checks passes. Analyse the failed checks and fix them

auto-merge was automatically disabled May 29, 2026 08:59

Head branch was pushed to by a user without write access

Copilot AI commented May 29, 2026

Copy link
Copy Markdown
Contributor

@copilot make sure all the checks passes. Analyse the failed checks and fix them

Fixed in ed47573: the root build now runs backend and frontend sequentially to prevent the validation npm ci race (ENOTEMPTY) that was failing the build check. The new workflow runs for this commit are currently in action_required, so once they’re approved/re-run, checks should proceed with this fix.

Copilot AI requested a review from yoganandaness May 29, 2026 09:00
@jekabs-karklins
jekabs-karklins enabled auto-merge (squash) June 4, 2026 06:06
yoganandaness
yoganandaness requested changes Jun 4, 2026
View reviewed changes

@yoganandaness yoganandaness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jekabs-karklins If you are fine, I can put back the concurrently.

Comment thread package.json

@yoganandaness yoganandaness Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jekabs-karklins

Do you think, this change is desired? I feel this would increase the build time, if it runs sequentially

@jekabs-karklins jekabs-karklins Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see it was updated by @copilot . Not sure why, but to me "concurrently" sounds like a right choice

@yoganandaness yoganandaness Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Can you revert this

Copilot AI Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in 03001bf: root build now uses concurrently "npm run build:backend" "npm run build:frontend" again.

auto-merge was automatically disabled June 4, 2026 09:59

Head branch was pushed to by a user without write access

Copilot AI requested a review from yoganandaness June 4, 2026 10:00
@github-actions
github-actions Bot enabled auto-merge June 4, 2026 11:52
@github-actions
github-actions Bot merged commit 7b4677a into develop Jun 4, 2026
22 checks passed
@github-actions
github-actions Bot deleted the dependabot-npm_and_yarn-apps-backend-multi-b38355ff25 branch June 4, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jekabs-karklins jekabs-karklins jekabs-karklins left review comments
@yoganandaness yoganandaness yoganandaness approved these changes
@William-Edwards-STFC William-Edwards-STFC Awaiting requested review from William-Edwards-STFC William-Edwards-STFC is a code owner automatically assigned from UserOfficeProject/stfc-user-programme
+1 more reviewer
Copilot code review Copilot Copilot left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoganandaness @jekabs-karklins