chore: change favicon from ess to generic - #1550
Conversation
Add FAVICON_FILENAME setting that allows each deployment to configure its own favicon, similar to HEADER_LOGO_FILENAME for the logo. - Add FAVICON_FILENAME to SettingsId enum - Add database migration (0212) to create the setting - Add DynamicFavicon component that updates the favicon from settings - Configure ESS and STFC environments with their favicon filenames - Move favicon files to /public/images/ for consistency - Update index.html and manifest.json references
|
Seems like the wrong favicon flashes on the screen before its loading. If we remove it from the manifest and index.html would it let the browsers cache the correct one to show up? I am having a hard time testing because it feels like my browser remembers the wrong one when it shouldn't, |
| link.type = 'image/x-icon'; | ||
| link.rel = 'shortcut icon'; | ||
| link.href = '/images/' + faviconFilename; | ||
| document.getElementsByTagName('head')[0].appendChild(link); |
There was a problem hiding this comment.
Wouldn't 100% of the time the link[rel*='icon'] be found and then you're adding a second one here: appendChild(link);
because its here:
<link rel="shortcut icon" href="/images/ess-favicon.ico" />
There was a problem hiding this comment.
I do appear to be wrong and there isn't two of them in the HEAD. Because link acts as a pointer
| document.querySelector("link[rel*='icon']") || | ||
| document.createElement('link'); | ||
| link.type = 'image/x-icon'; | ||
| link.rel = 'shortcut icon'; |
There was a problem hiding this comment.
new version is just "icon"
|
Can we have an image in the default too settings as well |
| DO | ||
| $$ | ||
| BEGIN | ||
| IF register_patch('AddFaviconFilenameSetting.sql', 'yoganandaness', 'Add favicon filename to settings', '2026-06-01') THEN |
There was a problem hiding this comment.
shouldn't that say copilot???
d2abfc1 to
7a0102a
Compare
7a0102a to
9ea589c
Compare
|
@zacharyjhankin Reverting the old changes and here is the new approach. Requesting for review again. |
|
lgtm, Though to be honest the copilot PR was good too? Did the AI do it all by itself? 
|
|
The title should be make the favicon generic |
yoganandaness
changed the title
yoganandaness
changed the title
Description
Updated the favicon file (
favicon.ico) with new content. Facilities who would require to use their own logo as a favicon can replace the favicon.ico with the respective logo during build time.Motivation and Context
Ensures the public favicon file is up-to-date.
How Has This Been Tested
Fixes
N/A
Changes
"name"property to "Users' Office"Depends on
N/A
Tests included/Docs Updated?