feat: expand/collapse all functionality for proposals and reviewers a… - #1575
Merged
ChongJiaChua merged 4 commits intoJun 24, 2026
Merged
Conversation
jekabs-karklins
requested changes
Jun 18, 2026
|
|
||
| //index each row and expand/collapse them | ||
| const toggleExpandAll = useCallback(() => { | ||
| setIsAllExpanded((prev) => { |
Contributor
There was a problem hiding this comment.
suggestion: Not a big issue but onToggleDetailPanel loop runs inside the setIsAllExpanded updater, but updaters must be pure functions, see caveats https://react.dev/reference/react/useState#caveats . can we somehow address this?
Contributor
Author
There was a problem hiding this comment.
thanks for bringing that up. I've moved the side effects outside of the updater so it is pure now.
jekabs-karklins
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UserOfficeProject/issue-tracker/issues/1599
Description
This PR adds an expand/collapse all button to the FAP proposals, reviews, and reviewers tables. The button renders inside the table header and toggles all detail panel rows open or closed with a single click.
Motivation and Context
Reviewing large FAP proposal lists required expanding each row individually to see reviewer assignments. This change allows users to expand or collapse all rows at once.
How Has This Been Tested
Fixes
Changes
Depends on
Tests included/Docs Updated?