Skip to content

fix: wrong Modal Header when adding users #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivoomiess merged 4 commits into from
Jul 6, 2026
Merged

fix: wrong Modal Header when adding users #1594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
647dcf1
fix: correct Data Access User modal header text
shivoomiess Jun 17, 2026
cb028b7
fix: hardcoded modal title for coproposer, data access user, visitor
shivoomiess Jun 22, 2026
7b2e939
Merge branch 'develop' into SWAP-5365-wrongheader
shivoomiess Jun 30, 2026
ae1c04e
Merge branch 'develop' into SWAP-5365-wrongheader
jekabs-karklins Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/frontend/src/components/common/UserManagementTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ export type UserManagementTableProps = {
title: string;
addButtonLabel?: string;
addButtonTooltip?: string;
/** Header shown at the top of the invite/selector modal */
addModalTitle?: string;
/** Disable the add button */
disabled?: boolean;
/** Custom actions to be passed to PeopleTable */
Expand All @@ -45,6 +47,7 @@ const UserManagementTable = ({
title,
addButtonLabel = 'Add',
addButtonTooltip = 'Add a participant',
addModalTitle,
disabled = false,
onUserAction,
excludeUserIds = [],
Expand Down Expand Up @@ -78,7 +81,7 @@ const UserManagementTable = ({
const InviteComponent = (
<ProposalPeopleSelectorModal
modalOpen={modalOpen}
title="Add co-proposers"
title={addModalTitle}
onClose={() => setOpen(false)}
onAddParticipants={handleAddParticipants}
excludeUserIds={[...users.map((user) => user.id), ...excludeUserIds]}
Expand Down
1 change: 1 addition & 0 deletions apps/frontend/src/components/proposal/CoProposers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const CoProposers = ({
{...props}
title="Co-Proposers"
addButtonTooltip="Add a co-proposer"
addModalTitle="Add co-proposers"
onUserAction={handleUserAction}
excludeUserIds={proposer ? [proposer.id] : []}
// QuickFix for material table changing immutable state
Expand Down
1 change: 1 addition & 0 deletions apps/frontend/src/components/proposal/DataAccessUsersModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ const DataAccessUsersModal = ({
setInvites={() => {}}
title="Data access users"
addButtonLabel="Add Data Access User"
addModalTitle="Add Data Access User"
excludeUserIds={excludeUserIds}
Comment on lines 88 to 91
/>
<ActionButtonContainer>
Expand Down
1 change: 1 addition & 0 deletions apps/frontend/src/components/proposalBooking/CreateUpdateVisit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ function CreateUpdateVisit({ event, close }: CreateUpdateVisitProps) {
</Typography>
<UserManagementTable
title="Visitors"
addModalTitle="Add Visitors"
setInvites={setVisitInvites}
invites={visitInvites}
setUsers={(team: BasicUserDetails[]) => {
Expand Down
Loading