refactor: return template id for question template relationship object - #1611
Merged
GrantDLS merged 1 commit intoJun 30, 2026
Conversation
jekabs-karklins
requested review from
William-Edwards-STFC
and removed request for
a team
June 29, 2026 12:26
jekabs-karklins
changed the title
Contributor
|
Looks good to me. Thank you for making this change @jekabs-karklins . This is exactly what I needed. |
GrantDLS
approved these changes
Jun 30, 2026
GrantDLS
merged commit Jun 30, 2026
5297af1
into
use-template-config-for-dynamic-multi-v2
2 checks passed
GrantDLS
deleted the
refactor-return-template-id-for-question-template-rel
branch
June 30, 2026 09:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a refactor to return the template ID for question template relationship object.
Motivation and Context
This PR addresses comment raised here where the template id was missing
#1582 (comment)
Template ID is an essential field for the question-template relationship object therefore it should be included in the return fields. This PR adds the field and utilizes in the apps/frontend/src/components/common/proposalFilters/QuestionaryFilter.tsx
Changes
How Has This Been Tested?
Manually and checking if the performance is not degrated