fix: getProposal api error

[ellen-wright]

Description

refs: UserOfficeProject/issue-tracker#1620
There has been an error when calling the getProposal api call that the isComplete cannot be null.
This can be resolved by allowing it to be null.

This includes schema changes that need to be approved

Tests included/Docs Updated?

• I have added tests to cover my changes.
• All relevant doc has been updated

[zacharyjhankin]

I don't understand the purpose of this PR. This API ultimately calls QuestionaryDataSource.ts (getIsCompleted) which returns a promise(boolean) So why do we need to allow the API to return null if it can't return null given its implementation? What is the issue you are facing?

[jekabs-karklins]

I also believe that the problem is somewhere else. By inspecting code I can see that if it is undefined or null in the datasource it should be set to false upstream

user-office-core/apps/backend/src/datasources/postgres/QuestionaryDataSource.ts

Line 444 in f1225fd

topic.is_complete || false,

I think we would want to investigate to see how does isComplete become null and fix it there, maybe?

[ellen-wright]

Thanks for the help, I will close this PR and do some more looking into it