feat: diamond production/staging settings no longer gets overwritten on deployments - #1619
Merged
Merged
Conversation
zacharyjhankin
requested review from
William-Edwards-STFC
and removed request for
a team
July 2, 2026 15:20
zacharyjhankin
marked this pull request as draft
July 2, 2026 15:22
GrantDLS
approved these changes
Jul 3, 2026
zacharyjhankin
marked this pull request as ready for review
July 6, 2026 07:20
zacharyjhankin
enabled auto-merge (squash)
July 6, 2026 10:22
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets diamond settings match the same logic as ESS where on prod/staging deployments the configuration does not get re-applied. This means that when someone in the user office role changes a setting it will not be overwritten the next time that we deploy.
However, the colours in staging and development are going to be set on deployment so it is clear what environment you are in. The settings in development will be auto set up for you. Staging and prod will be left the same so they can be configured as you like.
Tested locally.
Development colour:
staging colour:
I went with the dark purple in staging and the red in development because purple is closer to blue which is production so it reflects that you are closer to production.