Skip to content

fix: email and proposal download status action logs pages - #1622

Merged
mutambaraf merged 16 commits into
developfrom
1623-fix-status-action-logs
Jul 14, 2026
Merged

fix: email and proposal download status action logs pages#1622
mutambaraf merged 16 commits into
developfrom
1623-fix-status-action-logs

Conversation

@mutambaraf

Copy link
Copy Markdown
Contributor

Description

Closes: UserOfficeProject/issue-tracker#1623

The Email and Proposal Download status action logs pages were throwing a GraphQL INTERNAL_SERVER_ERROR ("Status action not found ActionId: X connectionId: Y") for most historical rows, because a data migration bug (the workflow-overhaul release) left many status_actions_logs rows pointing at connection_id/action_id combinations that no longer exist in workflow_status_connection_has_actions. This PR makes that a handled, expected state instead of a hard error, and prevents users from trying to replay a log that has no configuration left to replay against.

Motivation and Context

How Has This Been Tested

Added tests

Fixes

Changes

  • apps/backend/src/datasources/StatusActionsDataSource.ts — updated the getConnectionStatusAction interface signature to return ConnectionHasStatusAction | null.
  • apps/backend/src/datasources/postgres/StatusActionsDataSource.ts — getConnectionStatusAction returns null instead of throwing when no matching connection/action is found.
  • apps/frontend/src/components/statusActionsLogs/StatusActionsLogsTable.tsx — Replay action is visually and functionally disabled for rows with no connectionStatusAction, without breaking the tooltip.
  • apps/backend/src/mutations/StatusActionsLogsMutations.spec.ts — added a test asserting replay rejects gracefully when the connection/action can't be resolved.

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@mutambaraf
mutambaraf requested a review from a team as a code owner July 3, 2026 12:12
@mutambaraf
mutambaraf requested review from Scott-James-Hurley and removed request for a team July 3, 2026 12:12
@mutambaraf
mutambaraf requested review from a team and janosbabik and removed request for a team July 3, 2026 12:14
@mutambaraf mutambaraf changed the title fix: email and proposal download status action logs pages fix: email and proposal download status action logs pages Jul 3, 2026

@Scott-James-Hurley Scott-James-Hurley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Comment thread apps/backend/src/datasources/postgres/StatusActionsDataSource.ts
Comment thread apps/frontend/src/components/statusActionsLogs/StatusActionsLogsTable.tsx Outdated
@mutambaraf
mutambaraf merged commit 53100f3 into develop Jul 14, 2026
21 checks passed
@mutambaraf
mutambaraf deleted the 1623-fix-status-action-logs branch July 14, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken status action logs page

3 participants