feat: send email notifications to DAU newly added to a proposal#1626
Open
shivoomiess wants to merge 7 commits into
Open
feat: send email notifications to DAU newly added to a proposal#1626shivoomiess wants to merge 7 commits into
shivoomiess wants to merge 7 commits into
Conversation
jekabs-karklins
approved these changes
Jul 7, 2026
jekabs-karklins
left a comment
Contributor
There was a problem hiding this comment.
LGTM - one minor change request.
Non-blocking thought: wiring this only into essEmailHandler means any other facility wanting the same notification has to reimplement a near-identical handler. Might be worth rethinking the email-handling structure so common cases live in one place while facilities can still add their own. Follow-up, not for this PR.
…ser-office-core into SWAP-5655-notify-DAU
yoganandaness
requested review from
simonfernandes and
zacharyjhankin
and removed request for
janosbabik
July 20, 2026 09:28
simonfernandes
approved these changes
Jul 20, 2026
shivoomiess
enabled auto-merge (squash)
July 22, 2026 08:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the feature to send email notifications to Data Access User (DAU) when they are newly added to a proposal.
Motivation and Context
This change is required to ensure that newly added DAUs are promptly notified about their addition to a proposal, thereby improving communication and efficiency.
Changes
How Has This Been Tested
This has been tested by verifying that email notifications are sent out accurately to newly added DAUs, and no notifications are sent out in case of no new additions. Error handling has been implemented to log an error message if an email could not be sent.
The logs confirm this is the case:

Fixes Jira Issue
https://jira.ess.eu//browse/SWAP-5655
Depends On
Tests included/Docs Updated?