fix: remove redundant "Review" step from various template previews#1631
Merged
Conversation
multiple template states
simonfernandes
approved these changes
Jul 7, 2026
jekabs-karklins
approved these changes
Jul 14, 2026
yoganandaness
enabled auto-merge (squash)
July 20, 2026 09:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the redundant "Review" step from various template previews. A missing
previewModeparameter for the inheritedQuestionarySubmissionStatewas missing across various templates which has now been added.Motivation and Context
The change is required to streamline the template preview process by removing unnecessary steps, thus solving the problem of redundancy and improving user interaction.
Changes
previewModeproperty in various components to handle the removal of the "Review" step in preview mode. This flow already existed in the code, but some templates (listed below) were not passing the parameter to the QuestionaryState and this led to the "Review" tab being rendered.ExperimentSafetySubmissionState,GenericTemplateSubmissionState,SampleSubmissionState,ShipmentSubmissionState, andVisitRegistrationSubmissionStateclasses to accommodate the newpreviewModeproperty.ExperimentSafetyContainer,GenericTemplateContainer,SampleDeclarationContainer,ShipmentContainer, andVisitRegistrationContainercomponents to use the newpreviewModeproperty.How Has This Been Tested?
The author of this PR has confirmed that the "Review" step is now not visible in the template previews but is visible in the user's interactions with the Questionary components.
Fixes Jira Issue
https://jira.ess.eu//browse/SWAP-5658
Depends On
Tests included/Docs Updated?