fix: fap meetings bugs#1641
Open
TCMeldrum wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of bugs related to the functionality of FAP meetings.
Motivation and Context
The changes were necessary to improve the user experience for FAP Chairs and Secretaries, and to ensure the correct ordering of proposals based on their average score.
Changes
reorderFapMeetingDecisionProposalsmethod inFapMutations.tsfile to also includeRoles.FAP_CHAIRandRoles.FAP_SECRETARY. This allows FAP Chairs and Secretaries to reorder FAP meeting decision proposals.FapInstrumentProposalsTable.tsxfile. The proposals are now sorted in descending order of their average score, which means the proposal with the highest average score will be on top.How Has This Been Tested?
Fixes Jira Issue
https://jira.ess.eu//browse/
Depends On
Tests included/Docs Updated?