Skip to content

fix: get invite proposal null issue #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoganandaness merged 5 commits into from
Jul 21, 2026
Merged

fix: get invite proposal null issue #1655

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb0b0d1
Fix crash when invited proposal query returns no rows
Copilot Jul 20, 2026
8bbcfbd
Merge branch 'develop' into copilot/fix-properties-reading-error
yoganandaness Jul 20, 2026
33426eb
Refactor getInvitedProposal to use .first() per review suggestion
Copilot Jul 20, 2026
6eaf9e2
Merge branch 'develop' into copilot/fix-properties-reading-error
yoganandaness Jul 20, 2026
92af286
Merge branch 'develop' into copilot/fix-properties-reading-error
yoganandaness Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions apps/backend/src/datasources/postgres/ProposalDataSource.ts
View file
Open in desktop

@yoganandaness yoganandaness Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot

Here is my suggestion

async getInvitedProposal(inviteId: number): Promise<InvitedProposal | null> {
return await database
.select(
'proposals.proposal_id',
'proposer.firstname as proposer_name',
'proposals.abstract',
'proposals.title'
)
.from('co_proposer_claims')
.join('proposals', {
'co_proposer_claims.proposal_pk': 'proposals.proposal_pk',
})
.join('users as proposer', {
'proposals.proposer_id': 'proposer.user_id',
})
.where('invite_id', inviteId)
.first()
.then((proposal: InvitedProposalRecord) => {
return proposal ? createInvitedProposalObject(proposal) : null;
});
}

Copilot AI Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already implemented in commit 33426eb — getInvitedProposal uses .first() with the .then() guard exactly as suggested.

Original file line number Diff line number Diff line change
Expand Up @@ -1419,7 +1419,7 @@ export default class PostgresProposalDataSource implements ProposalDataSource {
}

async getInvitedProposal(inviteId: number): Promise<InvitedProposal | null> {
const proposals: InvitedProposalRecord[] | undefined = await database
return await database
.select(
'proposals.proposal_id',
'proposer.firstname as proposer_name',
Expand All @@ -1433,8 +1433,10 @@ export default class PostgresProposalDataSource implements ProposalDataSource {
.join('users as proposer', {
'proposals.proposer_id': 'proposer.user_id',
})
.where('invite_id', inviteId);

return proposals ? createInvitedProposalObject(proposals[0]) : null;
.where('invite_id', inviteId)
.first()
.then((proposal: InvitedProposalRecord | undefined) =>
proposal ? createInvitedProposalObject(proposal) : null
);
}
}
Loading