Skip to content

feat: add technique proposal rejection comment - #1691

Draft
ellen-wright wants to merge 3 commits into
developfrom
1533-add-technique-proposal-rejection-comment
Draft

feat: add technique proposal rejection comment#1691
ellen-wright wants to merge 3 commits into
developfrom
1533-add-technique-proposal-rejection-comment

Conversation

@ellen-wright

Copy link
Copy Markdown
Contributor

Description

refs: UserOfficeProject/issue-tracker#1533

Motivation and Context

Experiment Scientists would like to add a comment to emails when setting status to unsuccessful to explain their reasoning. Currently someone will reach out separately after this so this will give the user extra information on the proposal decision.

Changes

  • New database table - similar to Internal Scientist Comment
  • Adds new data source for the rejection comment
  • create mutation that checks if any previous comment was made for this proposal - this can only happen if a User Officer sets the status to a different status then back to unsuccessful and give a new comment, and adds the comment for the proposal to the db
  • get function to retrieve the comment and allow it to be shown in an email to the user.
  • A new modal that appears when the status of a technique proposal is set to unsuccessful
    • This allows the option for no comment to be set
    • This modal appears before the confirmation to change the status - if the user does not confirm the status change the rejection comment will not be set
  • The rejection comment is exposed to be able to be used in emails

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@ellen-wright
ellen-wright requested a review from a team as a code owner July 30, 2026 12:47
@ellen-wright
ellen-wright requested review from ACLay, jekabs-karklins and mutambaraf and removed request for a team and ACLay July 30, 2026 12:47
@ellen-wright ellen-wright changed the title 1533 add technique proposal rejection comment feat: add technique proposal rejection comment Jul 30, 2026
@ellen-wright
ellen-wright marked this pull request as draft July 30, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant