feat: add call filter to the scheduler and improve navigation experience#43
Merged
martin-trajanovski merged 10 commits intoNov 14, 2023
Merged
Conversation
martin-trajanovski
marked this pull request as ready for review
November 3, 2023 13:24
janosbabik
reviewed
Nov 7, 2023
janosbabik
left a comment
janosbabik
left a comment
Contributor
There was a problem hiding this comment.
Nice job! I've added some comments for your consideration.
Contributor
Author
@janosbabik thanks for the good feedback. I have checked all the comments and they should be resolved now. |
janosbabik
approved these changes
Nov 14, 2023
martin-trajanovski
deleted the
SWAP-3060-add-call-filter-in-scheduler
branch
November 14, 2023 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add call filter inside scheduler toolbar where it allows you to select a specific call and see events and bookings only for the selected one.
This functionality will be extended in the next PR: #44 with adding new view period called cycle which will allow the instrument scientists to select a call and view the booked events only in the call's cycle period.
Motivation and Context
There was no call filter and by default all the events and bookings were shown from all the calls.
How Has This Been Tested
Fixes
https://jira.esss.lu.se/browse/SWAP-3060
Changes
Screenshare.-.2023-11-03.2_19_02.PM.mp4
Depends on
Tests included/Docs Updated?