Skip to content

Explanation of pull request #11

@RosaMGini

Description

@RosaMGini

dear @YMao-UMCU

thank you very much for fixing the bug and gfor generating the package

i accpted the pull request but then i experienced some issue sin running the examples. for this reason i created this pull request with some modifications, but maybe there is something i am not geeting of your structure

  • i added the dependency on data.table in a file package.R that then roxygen saved in NAMESPACE: without that, the code would not run for me
  • in tests/test_specific_example i modified the lines that load the function, and now it the file correcty loads the package and runs. i also fixed the ground truth as you suggested

however, i feel that perhaps i am missing now the structure of the tests that you have in mind. let's discuss at the next Programming TF meeting, and then i will update the README accordingly

also, shall you update the README file? now it points to the old manner to load the function. i am hesitant to do it myself because i am not 100% sure i understand your vision

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions