Skip to content

Commit 73c2c10

Browse files
authored
Upgrade to Node 24 (#1509)
* upgrade to Node 24 * upgrade node in npm-publish-sites.yml too * use Node 24 in tests job too * add repository info in package.json * remove old respository entry in ortho package.json * fix awaited import that node 24 didn't like
1 parent 8205993 commit 73c2c10

11 files changed

Lines changed: 213 additions & 129 deletions

File tree

.github/workflows/npm-publish-sites.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- uses: actions/checkout@v4
3636
- uses: actions/setup-node@v4
3737
with:
38-
node-version: 14
38+
node-version: 24
3939
cache: yarn
4040
- run: yarn
4141
- run: yarn nx bundle:npm @veupathdb/${{matrix.dir}}
@@ -71,7 +71,7 @@ jobs:
7171
- uses: actions/checkout@v4
7272
- uses: actions/setup-node@v4
7373
with:
74-
node-version: 14
74+
node-version: 24
7575
cache: yarn
7676
- run: yarn
7777
- run: ./tools/scripts/test-report

package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"@types/react-dom": "^18.0.0",
1313
"react": "^18.0.0",
1414
"react-dom": "^18.0.0",
15-
"react-error-overlay": "6.0.9"
15+
"react-error-overlay": "6.0.9",
16+
"ttf2woff2": "^4.0.5"
1617
},
1718
"devDependencies": {
1819
"@veupathdb/browserslist-config": "workspace:^",
@@ -30,14 +31,14 @@
3031
"*.{js,jsx,ts,tsx,css,scss,md}": "prettier --write"
3132
},
3233
"volta": {
33-
"node": "16.17.1",
34+
"node": "24.11.0",
3435
"yarn": "3.3.1"
3536
},
3637
"engines": {
37-
"node": "<=16.17.1"
38+
"node": ">=24.0.0"
3839
},
3940
"dependencies": {
4041
"webpack": "^5.84.1",
41-
"webpack-cli": "^5.1.1"
42+
"webpack-cli": "^6.0.1"
4243
}
4344
}

packages/sites/clinepi-site/package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
{
22
"name": "@veupathdb/clinepi-site",
33
"version": "1.0.1",
4+
"repository": {
5+
"type": "git",
6+
"url": "https://github.com/VEuPathDB/web-monorepo"
7+
},
48
"description": "",
59
"scripts": {
610
"test": "echo \"Error: no test specified\" && exit 1",

packages/sites/clinepi-site/webpack.config.local.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import {
77
makeCommonDevServerConfig,
88
} from '@veupathdb/react-scripts/utils/dev-server-config.js';
99

10-
const __dirname = dirname(fileURLToPath(import.meta.url));
10+
import configure from '@veupathdb/site-webpack-config';
11+
import { additionalConfig } from './webpack.config.js';
1112

12-
const { default: configure } = await import('@veupathdb/site-webpack-config');
13-
const { additionalConfig } = await import('./webpack.config.js');
13+
const __dirname = dirname(fileURLToPath(import.meta.url));
1414

1515
export default configure({
1616
...additionalConfig,

packages/sites/genomics-site/package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
{
22
"name": "@veupathdb/genomics-site",
33
"version": "1.0.1",
4+
"repository": {
5+
"type": "git",
6+
"url": "https://github.com/VEuPathDB/web-monorepo"
7+
},
48
"main": "index.js",
59
"license": "MIT",
610
"scripts": {

packages/sites/genomics-site/webpack.config.local.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import {
77
makeCommonDevServerConfig,
88
} from '@veupathdb/react-scripts/utils/dev-server-config.js';
99

10-
const __dirname = dirname(fileURLToPath(import.meta.url));
10+
import configure from '@veupathdb/site-webpack-config';
11+
import { additionalConfig } from './webpack.config.js';
1112

12-
const { default: configure } = await import('@veupathdb/site-webpack-config');
13-
const { additionalConfig } = await import('./webpack.config.js');
13+
const __dirname = dirname(fileURLToPath(import.meta.url));
1414

1515
export default configure({
1616
...additionalConfig,

packages/sites/mbio-site/package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
{
22
"name": "@veupathdb/mbio-site",
33
"version": "1.0.1",
4+
"repository": {
5+
"type": "git",
6+
"url": "https://github.com/VEuPathDB/web-monorepo"
7+
},
48
"description": "",
59
"scripts": {
610
"test": "echo \"Error: no test specified\" && exit 1",

packages/sites/mbio-site/webpack.config.local.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import {
77
makeCommonDevServerConfig,
88
} from '@veupathdb/react-scripts/utils/dev-server-config.js';
99

10-
const __dirname = dirname(fileURLToPath(import.meta.url));
10+
import configure from '@veupathdb/site-webpack-config';
11+
import { additionalConfig } from './webpack.config.js';
1112

12-
const { default: configure } = await import('@veupathdb/site-webpack-config');
13-
const { additionalConfig } = await import('./webpack.config.js');
13+
const __dirname = dirname(fileURLToPath(import.meta.url));
1414

1515
export default configure({
1616
...additionalConfig,

packages/sites/ortho-site/package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
{
22
"name": "@veupathdb/ortho-site",
33
"version": "1.0.1",
4+
"repository": {
5+
"type": "git",
6+
"url": "https://github.com/VEuPathDB/web-monorepo"
7+
},
48
"main": "index.js",
5-
"repository": "https://github.com/VEuPathDB/OrthoMCLClient",
69
"license": "MIT",
710
"scripts": {
811
"start": "veupathdb-react-scripts run-site-dev-server --config webpack.config.local.mjs",

packages/sites/ortho-site/webpack.config.local.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import {
77
makeCommonDevServerConfig,
88
} from '@veupathdb/react-scripts/utils/dev-server-config.js';
99

10-
const __dirname = dirname(fileURLToPath(import.meta.url));
10+
import configure from '@veupathdb/site-webpack-config';
11+
import { additionalConfig } from './webpack.config.js';
1112

12-
const { default: configure } = await import('@veupathdb/site-webpack-config');
13-
const { additionalConfig } = await import('./webpack.config.js');
13+
const __dirname = dirname(fileURLToPath(import.meta.url));
1414

1515
export default configure({
1616
...additionalConfig,

0 commit comments

Comments
 (0)