Payment form invoice number input#1385
Open
bobular wants to merge 5 commits into
Open
Conversation
…ndled service call
ryanrdoherty
approved these changes
May 1, 2025
…eneral' errors to above submit button
Member
Author
|
I've added invoice number validation on the front end too - was this a good idea? (There is now duplication of the back end regexp here in the front end.)
|
Member
|
I don't have a problem with validation duplication. The mantra I've always heard is: back-end validation is necessary, front-end, sublime. Better to catch this right away with a nice message than show the spinner and then possibly not handle as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's what it looks like
Notice there are now placeholders and the dollar amount is right-justified.