Conditionally render entire files section based on existence of files#1746
Open
bobular wants to merge 1 commit into
Open
Conditionally render entire files section based on existence of files#1746bobular wants to merge 1 commit into
bobular wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the UserDatasetFiles UI to avoid rendering the dataset files section when there are no files available, preventing users from seeing broken download links when an upload did not succeed.
Changes:
- Add an early return to skip rendering the files section when file data is missing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+98
to
+101
| // No need for this section if there are no data files at all | ||
| // (e.g. upload failure) | ||
| const hasUpload = files.upload != null; | ||
| if (!hasUpload) return null; |
steve-fischer-200
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we had broken file download link in the "Uploaded Files in Dataset" section. Now we just skip the entire "Data Files" section. See below: