Increased coverage + more tests

Author: JanPetterMG

src/UserAgentParser.php

@@ -96,15 +96,13 @@ private function validateProduct()
      */
     private function blacklistCheck($input)
     {
-        foreach (
-            [
-                'mozilla',
-                'compatible',
-                '(',
-                ')',
-                ' ',
-            ] as $string
-        ) {
+        foreach ([
+                     'mozilla',
+                     'compatible',
+                     '(',
+                     ')',
+                     ' ',
+                 ] as $string) {
             if (stripos($input, $string) !== false) {
                 throw new FormatException('Invalid User-agent format (`' . trim($this->product . '/' . $this->version, '/') . '`). Examples of valid User-agents: `MyCustomBot`, `MyFetcher-news`, `MyCrawler/2.1` and `MyBot-images/1.2`. See also ' . self::RFC_README);
             }

tests/MatchTest.php

@@ -61,6 +61,14 @@ public function generateDataForTest()
                     'mybot/2.2',
                 ]
             ],
+            [
+                'h3lloBot/2.1',
+                'h3lloBot/2',
+                [
+                    'h3lloBot',
+                    'h3lloBot/2',
+                ]
+            ],
             [
                 'googlebot',
                 false,
@@ -77,7 +85,7 @@ public function generateDataForTest()
                     'UPPERCASE-lowercase',
                     'UPPERCASE-lowercase/1.0',
                 ]
-            ]
+            ],
         ];
     }
 }

tests/TruncateInvalidTest.php

@@ -0,0 +1,41 @@
+<?php
+namespace vipnytt\UserAgentParser\Tests;
+
+use vipnytt\UserAgentParser;
+
+/**
+ * Class TruncateInvalidTest
+ *
+ * @package vipnytt\UserAgentParser\Tests
+ */
+class TruncateInvalidTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @dataProvider generateDataForTest
+     * @param string $product
+     * @param int|string|null $version
+     * @expectedException \PHPUnit_Framework_Error_Warning
+     */
+    public function testTruncateInvalid($product, $version)
+    {
+        new UserAgentParser($product, $version);
+    }
+
+    /**
+     * Generate test data
+     * @return array
+     */
+    public function generateDataForTest()
+    {
+        return [
+            [
+                'MyÇustomWebCrawler',
+                '2.0',
+            ],
+            [
+                'MyCøstomWebCræwler',
+                '2.0',
+            ],
+        ];
+    }
+}