[k2] add confdata request cache (#1430)

Author: apolyakov

runtime-light/state/instance-state.h

@@ -21,6 +21,7 @@
 #include "runtime-light/server/job-worker/job-worker-server-state.h"
 #include "runtime-light/server/rpc/rpc-server-state.h"
 #include "runtime-light/state/component-state.h"
+#include "runtime-light/stdlib/confdata/confdata-state.h"
 #include "runtime-light/stdlib/curl/curl-state.h"
 #include "runtime-light/stdlib/diagnostics/contextual-logger.h"
 #include "runtime-light/stdlib/diagnostics/error-handling-state.h"
@@ -102,6 +103,7 @@ struct InstanceState final : vk::not_copyable {
   JobWorkerClientInstanceState job_worker_client_instance_state;
   JobWorkerServerInstanceState job_worker_server_instance_state;
   InstanceCacheInstanceState instance_cache_instance_state;
+  ConfdataInstanceState confdata_instance_state;
 
   TimeInstanceState time_instance_state;
   MathInstanceState math_instance_state;

runtime-light/stdlib/confdata/confdata-functions.cpp

@@ -18,6 +18,7 @@
 #include "runtime-light/k2-platform/k2-api.h"
 #include "runtime-light/stdlib/component/component-api.h"
 #include "runtime-light/stdlib/confdata/confdata-constants.h"
+#include "runtime-light/stdlib/confdata/confdata-state.h"
 #include "runtime-light/stdlib/diagnostics/logs.h"
 #include "runtime-light/stdlib/fork/fork-functions.h"
 #include "runtime-light/streams/read-ext.h"
@@ -45,6 +46,11 @@ mixed extract_confdata_value(const tl::confdataValue& confdata_value) noexcept {
 } // namespace
 
 kphp::coro::task<mixed> f$confdata_get_value(const string& key) noexcept {
+  auto& confdata_key_cache{ConfdataInstanceState::get().key_cache()};
+  if (auto it{confdata_key_cache.find(key)}; it != confdata_key_cache.end()) {
+    co_return it->second;
+  }
+
   tl::ConfdataGet confdata_get{.key = {.value = {key.c_str(), key.size()}}};
   tl::storer tls{confdata_get.footprint()};
   confdata_get.store(tls);
@@ -67,12 +73,20 @@ kphp::coro::task<mixed> f$confdata_get_value(const string& key) noexcept {
   if (!maybe_confdata_value.opt_value) { // no such key
     co_return mixed{};
   }
-  co_return extract_confdata_value(*maybe_confdata_value.opt_value); // the key exists
+
+  auto value{extract_confdata_value(*maybe_confdata_value.opt_value)}; // the key exists
+  confdata_key_cache.emplace(key, value);
+  co_return std::move(value);
 }
 
 kphp::coro::task<array<mixed>> f$confdata_get_values_by_any_wildcard(const string& wildcard) noexcept {
   static constexpr size_t CONFDATA_GET_WILDCARD_STREAM_CAPACITY = 1 << 20;
 
+  auto& confdata_wildcard_cache{ConfdataInstanceState::get().wildcard_cache()};
+  if (auto it{confdata_wildcard_cache.find(wildcard)}; it != confdata_wildcard_cache.end()) {
+    co_return it->second;
+  }
+
   tl::ConfdataGetWildcard confdata_get_wildcard{.wildcard = {.value = {wildcard.c_str(), wildcard.size()}}};
   tl::storer tls{confdata_get_wildcard.footprint()};
   confdata_get_wildcard.store(tls);
@@ -98,5 +112,6 @@ kphp::coro::task<array<mixed>> f$confdata_get_values_by_any_wildcard(const strin
     result.set_value(string{dict_field.key.value.data(), static_cast<string::size_type>(dict_field.key.value.size())},
                      extract_confdata_value(dict_field.value));
   });
+  confdata_wildcard_cache.emplace(wildcard, result);
   co_return std::move(result);
 }

runtime-light/stdlib/confdata/confdata-state.cpp

@@ -0,0 +1,11 @@
+// Compiler for PHP (aka KPHP)
+// Copyright (c) 2025 LLC «V Kontakte»
+// Distributed under the GPL v3 License, see LICENSE.notice.txt
+
+#include "runtime-light/stdlib/confdata/confdata-state.h"
+
+#include "runtime-light/state/instance-state.h"
+
+ConfdataInstanceState& ConfdataInstanceState::get() noexcept {
+  return InstanceState::get().confdata_instance_state;
+}

runtime-light/stdlib/confdata/confdata-state.h

@@ -0,0 +1,32 @@
+// Compiler for PHP (aka KPHP)
+// Copyright (c) 2025 LLC «V Kontakte»
+// Distributed under the GPL v3 License, see LICENSE.notice.txt
+
+#pragma once
+
+#include <cstddef>
+
+#include "common/mixin/not_copyable.h"
+#include "runtime-common/core/allocator/script-allocator.h"
+#include "runtime-common/core/runtime-core.h"
+#include "runtime-common/core/std/containers.h"
+
+class ConfdataInstanceState final : private vk::not_copyable {
+  using hasher_type = decltype([](const string& s) noexcept { return static_cast<size_t>(s.hash()); });
+
+  kphp::stl::unordered_map<string, mixed, kphp::memory::script_allocator, hasher_type> m_key_cache;
+  kphp::stl::unordered_map<string, array<mixed>, kphp::memory::script_allocator, hasher_type> m_wildcard_cache;
+
+public:
+  ConfdataInstanceState() noexcept = default;
+
+  auto& key_cache() noexcept {
+    return m_key_cache;
+  }
+
+  auto& wildcard_cache() noexcept {
+    return m_wildcard_cache;
+  }
+
+  static ConfdataInstanceState& get() noexcept;
+};

runtime-light/stdlib/stdlib.cmake

@@ -2,6 +2,7 @@ prepend(
   RUNTIME_LIGHT_STDLIB_SRC
   stdlib/
   confdata/confdata-functions.cpp
+  confdata/confdata-state.cpp
   crypto/crypto-functions.cpp
   curl/curl-state.cpp
   diagnostics/backtrace.cpp