Skip to content

Commit 8a0992e

Browse files
authored
[k2] make naming of Web Transfer Lib more clear (#1647)
1 parent 733c856 commit 8a0992e

8 files changed

Lines changed: 210 additions & 196 deletions

File tree

runtime-light/stdlib/curl/curl-easy-functions.h

Lines changed: 34 additions & 34 deletions
Large diffs are not rendered by default.

runtime-light/stdlib/curl/curl-multi-functions.h

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include "runtime-light/stdlib/web-transfer-lib/web-simple-transfer.h"
2424

2525
inline auto f$curl_multi_init() noexcept -> kphp::coro::task<kphp::web::curl::multi_type> {
26-
auto open_res{co_await kphp::forks::id_managed(kphp::web::composite_transfer_open(kphp::web::transfer_backend::CURL))};
26+
auto open_res{co_await kphp::forks::id_managed(kphp::web::composite::open(kphp::web::transfer_backend::CURL))};
2727
if (!open_res.has_value()) [[unlikely]] {
2828
kphp::web::curl::print_warning("could not initialize a new curl multi handle", std::move(open_res.error()));
2929
co_return 0;
@@ -45,7 +45,7 @@ inline auto f$curl_multi_add_handle(kphp::web::curl::multi_type multi_id, kphp::
4545
auto& easy_ctx{curl_state.easy_ctx.get_or_init(easy_id)};
4646
easy_ctx.errors_reset();
4747

48-
auto res{co_await kphp::forks::id_managed(kphp::web::composite_transfer_add(kphp::web::composite_transfer{multi_id}, kphp::web::simple_transfer{easy_id}))};
48+
auto res{co_await kphp::forks::id_managed(kphp::web::composite::add(kphp::web::composite::transfer{multi_id}, kphp::web::simple::transfer{easy_id}))};
4949
if (!res.has_value()) [[unlikely]] {
5050
multi_ctx.set_errno(res.error().code);
5151
kphp::web::curl::print_warning("could not add a curl easy handler into multi handle", std::move(res.error()));
@@ -65,8 +65,7 @@ inline auto f$curl_multi_remove_handle(kphp::web::curl::multi_type multi_id,
6565
if (!curl_state.easy_ctx.has(easy_id)) [[unlikely]] {
6666
co_return false;
6767
}
68-
auto res{
69-
co_await kphp::forks::id_managed(kphp::web::composite_transfer_remove(kphp::web::composite_transfer{multi_id}, kphp::web::simple_transfer{easy_id}))};
68+
auto res{co_await kphp::forks::id_managed(kphp::web::composite::remove(kphp::web::composite::transfer{multi_id}, kphp::web::simple::transfer{easy_id}))};
7069
if (!res.has_value()) [[unlikely]] {
7170
multi_ctx.set_errno(res.error().code);
7271
kphp::web::curl::print_warning("could not remove a curl easy handler from multi handle", std::move(res.error()));
@@ -82,7 +81,7 @@ inline auto f$curl_multi_setopt(kphp::web::curl::multi_type multi_id, int64_t op
8281
return false;
8382
}
8483
auto& multi_ctx{curl_state.multi_ctx.get_or_init(multi_id)};
85-
auto ct{kphp::web::composite_transfer{.descriptor = multi_id}};
84+
auto ct{kphp::web::composite::transfer{.descriptor = multi_id}};
8685

8786
switch (static_cast<kphp::web::curl::CURMLOPT>(option)) {
8887
// long options
@@ -92,7 +91,7 @@ inline auto f$curl_multi_setopt(kphp::web::curl::multi_type multi_id, int64_t op
9291
case kphp::web::curl::CURLPIPE::NOTHING:
9392
case kphp::web::curl::CURLPIPE::HTTP1:
9493
case kphp::web::curl::CURLPIPE::MULTIPLEX: {
95-
auto res{kphp::web::set_transfer_property(ct, option, kphp::web::property_value::as_long(std::to_underlying(pipeling_type)))};
94+
auto res{kphp::web::property::set(ct, option, kphp::web::property::value::as_long(std::to_underlying(pipeling_type)))};
9695
if (!res.has_value()) [[unlikely]] {
9796
kphp::web::curl::print_warning("could not set an mutli option", std::move(res.error()));
9897
return false;
@@ -109,7 +108,7 @@ inline auto f$curl_multi_setopt(kphp::web::curl::multi_type multi_id, int64_t op
109108
case kphp::web::curl::CURMLOPT::MAX_HOST_CONNECTIONS:
110109
case kphp::web::curl::CURMLOPT::MAX_PIPELINE_LENGTH:
111110
case kphp::web::curl::CURMLOPT::MAX_TOTAL_CONNECTIONS: {
112-
auto res{kphp::web::set_transfer_property(ct, option, kphp::web::property_value::as_long(value))};
111+
auto res{kphp::web::property::set(ct, option, kphp::web::property::value::as_long(value))};
113112
if (!res.has_value()) [[unlikely]] {
114113
kphp::web::curl::print_warning("could not set an multi option", std::move(res.error()));
115114
return false;
@@ -128,7 +127,7 @@ inline auto f$curl_multi_exec(kphp::web::curl::multi_type multi_id, int64_t& sti
128127
if (!curl_state.multi_ctx.has(multi_id)) [[unlikely]] {
129128
co_return false;
130129
}
131-
auto res{co_await kphp::forks::id_managed(kphp::web::composite_transfer_perform(kphp::web::composite_transfer{multi_id}))};
130+
auto res{co_await kphp::forks::id_managed(kphp::web::composite::perform(kphp::web::composite::transfer{multi_id}))};
132131
auto& multi_ctx{curl_state.multi_ctx.get_or_init(multi_id)};
133132
if (!res.has_value()) [[unlikely]] {
134133
multi_ctx.set_errno(res.error().code);
@@ -147,7 +146,7 @@ inline auto f$curl_multi_getcontent(kphp::web::curl::easy_type easy_id) noexcept
147146
}
148147
auto& easy_ctx{curl_state.easy_ctx.get_or_init(easy_id)};
149148
if (easy_ctx.return_transfer) {
150-
auto res{co_await kphp::forks::id_managed(kphp::web::simple_transfer_get_response(kphp::web::simple_transfer{easy_id}))};
149+
auto res{co_await kphp::forks::id_managed(kphp::web::simple::get_response(kphp::web::simple::transfer{easy_id}))};
151150
if (!res.has_value()) [[unlikely]] {
152151
easy_ctx.set_errno(res.error().code);
153152
kphp::web::curl::print_warning("could not get response of curl easy handle", std::move(res.error()));
@@ -164,7 +163,7 @@ inline auto f$curl_multi_close(kphp::web::curl::multi_type multi_id) noexcept ->
164163
co_return;
165164
}
166165
auto& multi_ctx{curl_state.multi_ctx.get_or_init(multi_id)};
167-
auto res{co_await kphp::forks::id_managed(kphp::web::composite_transfer_close(kphp::web::composite_transfer{multi_id}))};
166+
auto res{co_await kphp::forks::id_managed(kphp::web::composite::close(kphp::web::composite::transfer{multi_id}))};
168167
if (!res.has_value()) [[unlikely]] {
169168
multi_ctx.set_errno(res.error().code);
170169
kphp::web::curl::print_warning("could not close curl multi handle", std::move(res.error()));
@@ -224,8 +223,8 @@ inline auto f$curl_multi_select(kphp::web::curl::multi_type multi_id, double tim
224223
co_return false;
225224
}
226225
auto& multi_ctx{curl_state.multi_ctx.get_or_init(multi_id)};
227-
auto res{co_await kphp::forks::id_managed(kphp::web::composite_transfer_wait_updates(
228-
kphp::web::composite_transfer{multi_id}, std::chrono::duration_cast<std::chrono::seconds>(std::chrono::duration<double>{timeout})))};
226+
auto res{co_await kphp::forks::id_managed(kphp::web::composite::wait_updates(
227+
kphp::web::composite::transfer{multi_id}, std::chrono::duration_cast<std::chrono::seconds>(std::chrono::duration<double>{timeout})))};
229228
if (!res.has_value()) [[unlikely]] {
230229
multi_ctx.set_errno(res.error().code);
231230
kphp::web::curl::print_warning("could not select curl multi handle", std::move(res.error()));
@@ -245,7 +244,7 @@ inline auto f$curl_multi_info_read(kphp::web::curl::multi_type multi_id,
245244
constexpr auto CURL_MULTI_INFO_READ_OPTION = 0;
246245

247246
auto props{co_await kphp::forks::id_managed(
248-
kphp::web::get_transfer_properties(kphp::web::composite_transfer{multi_id}, CURL_MULTI_INFO_READ_OPTION, kphp::web::get_properties_policy::load))};
247+
kphp::web::property::get(kphp::web::composite::transfer{multi_id}, CURL_MULTI_INFO_READ_OPTION, kphp::web::property::get_policy::load))};
249248
if (!props.has_value()) [[unlikely]] {
250249
multi_ctx.set_errno(props.error().code, props.error().description);
251250
kphp::web::curl::print_warning("could not get info message of multi handle", std::move(props.error()));

runtime-light/stdlib/curl/defs.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ enum class PHPCURL : uint64_t {
1616
RETURNTRANSFER = 1234567,
1717
};
1818

19-
using easy_type = simple_transfer::descriptor_type;
20-
using multi_type = composite_transfer::descriptor_type;
19+
using easy_type = simple::transfer::descriptor_type;
20+
using multi_type = composite::transfer::descriptor_type;
2121

2222
constexpr auto CURL_DIAGNOSTICS_MSG_SIZE = 256;
2323

0 commit comments

Comments
 (0)