move math functions to runtime-common (#1420)

* move math functions to runtime-common

* enable tests

* reformat math-functions.txt

Author: Shamzik

builtin-functions/kphp-light/stdlib/math-functions.txt

@@ -41,6 +41,27 @@ function hexdec ($number ::: string): int;
  */
 function abs ($v ::: mixed) ::: ^1 | int;
 
+/**
+ * @kphp-extern-func-info
+ * @kphp-pure-function
+ */
+function acos ($v ::: float) ::: float;
+
+/**
+ * @kphp-extern-func-info
+ * @kphp-pure-function
+ */
+function atan ($v ::: float) ::: float;
+
+/**
+ * @kphp-extern-func-info
+ * @kphp-pure-function
+ */
+function atan2 ($y ::: float, $x ::: float) ::: float;
+
+/** @kphp-extern-func-info */
+function bindec ($number ::: string) ::: int;
+
 /**
  * @kphp-pure-function
  */
@@ -51,16 +72,31 @@ function ceil ($v ::: float) ::: float;
  */
 function cos ($v ::: float) ::: float;
 
+/** @kphp-extern-func-info */
+function decbin ($number ::: int) ::: string;
+
 /**
  * @kphp-pure-function
  */
 function deg2rad ($v ::: float) ::: float;
 
+/**
+ * @kphp-extern-func-info
+ * @kphp-pure-function
+ */
+function exp ($v ::: float) ::: float;
+
 /**
  * @kphp-pure-function
  */
 function floor ($v ::: float) ::: float;
 
+/** @kphp-extern-func-info */
+function is_finite ($v ::: float) ::: bool;
+
+/** @kphp-extern-func-info */
+function is_infinite ($v ::: float) ::: bool;
+
 /**
  * @kphp-pure-function
  */
@@ -71,11 +107,23 @@ function log ($v ::: float, $base ::: float = 2.7182818284590452353602874713527)
  */
 function round ($v ::: float, $precision ::: int = 0) ::: float;
 
+/**
+ * @kphp-extern-func-info
+ * @kphp-pure-function
+ */
+function sin ($v ::: float) ::: float;
+
 /**
  * @kphp-pure-function
  */
 function sqrt ($v ::: float) ::: float;
 
+/**
+ * @kphp-extern-func-info
+ * @kphp-pure-function
+ */
+function tan ($v ::: float) ::: float;
+
 /**
  * @kphp-pure-function
  */
@@ -116,41 +164,11 @@ function levenshtein ($str1 ::: string, $str2 ::: string) ::: int;
 
 // === UNSUPPORTED ===
 
-/**
- * @kphp-extern-func-info stub generation-required
- * @kphp-pure-function
- */
-function acos ($v ::: float) ::: float;
-/**
- * @kphp-extern-func-info stub generation-required
- * @kphp-pure-function
- */
-function atan ($v ::: float) ::: float;
-/**
- * @kphp-extern-func-info stub generation-required
- * @kphp-pure-function
- */
-function atan2 ($y ::: float, $x ::: float) ::: float;
-/**
- * @kphp-extern-func-info stub generation-required
- * @kphp-pure-function
- */
-function exp ($v ::: float) ::: float;
 /**
  * @kphp-extern-func-info stub generation-required
  * @kphp-pure-function
  */
 function fmod ($x ::: float, $y ::: float) ::: float;
-/**
- * @kphp-extern-func-info stub generation-required
- * @kphp-pure-function
- */
-function sin ($v ::: float) ::: float;
-/**
- * @kphp-extern-func-info stub generation-required
- * @kphp-pure-function
- */
-function tan ($v ::: float) ::: float;
 /**
  * @kphp-extern-func-info stub generation-required
  * @kphp-pure-function
@@ -168,17 +186,7 @@ define('PHP_ROUND_HALF_DOWN', 123423144);
 define('PHP_ROUND_HALF_EVEN', 123423145);
 define('PHP_ROUND_HALF_ODD', 123423146);
 
-/** @kphp-extern-func-info stub generation-required */
-function is_finite ($v ::: float) ::: bool;
-/** @kphp-extern-func-info stub generation-required */
-function is_infinite ($v ::: float) ::: bool;
 /** @kphp-extern-func-info stub generation-required */
 function random_int($l ::: int, $r ::: int) ::: int | false;
 /** @kphp-extern-func-info stub generation-required */
 function random_bytes($length ::: int) ::: string | false;
-
-/** @kphp-extern-func-info stub generation-required */
-function bindec ($number ::: string) ::: int;
-
-/** @kphp-extern-func-info stub generation-required */
-function decbin ($number ::: int) ::: string;

runtime-common/stdlib/math/math-functions.cpp

@@ -13,6 +13,44 @@
 #include "runtime-common/stdlib/string/string-context.h"
 #include "runtime-common/stdlib/string/string-functions.h"
 
+int64_t f$bindec(const string& number) noexcept {
+  uint64_t v = 0;
+  bool bad_str_param = number.empty();
+  bool overflow = false;
+  for (string::size_type i = 0; i < number.size(); i++) {
+    const char c = number[i];
+    if (likely(vk::any_of_equal(c, '0', '1'))) {
+      v = math_functions_impl_::mult_and_add<2>(v, static_cast<uint8_t>(c - '0'), overflow);
+    } else {
+      bad_str_param = true;
+    }
+  }
+
+  if (unlikely(bad_str_param)) {
+    php_warning("Wrong parameter '%s' in function bindec", number.c_str());
+  }
+  if (unlikely(overflow)) {
+    php_warning("Integer overflow on converting '%s' in function bindec, "
+                "the result will be different from PHP",
+                number.c_str());
+  }
+  return static_cast<int64_t>(v);
+}
+
+string f$decbin(int64_t number) noexcept {
+  auto v = static_cast<uint64_t>(number);
+
+  char s[66];
+  int i = 65;
+
+  do {
+    s[--i] = static_cast<char>((v & 1) + '0');
+    v >>= 1;
+  } while (v > 0);
+
+  return {s + i, static_cast<string::size_type>(65 - i)};
+}
+
 string f$dechex(int64_t number) noexcept {
   auto v = static_cast<uint64_t>(number);
 

runtime-common/stdlib/math/math-functions.h

@@ -22,14 +22,30 @@ uint64_t mult_and_add(uint64_t x, uint8_t y, bool& overflow) noexcept {
 
 } // namespace math_functions_impl_
 
+inline double f$acos(double v) noexcept;
+
+inline double f$atan(double v) noexcept;
+
+inline double f$atan2(double y, double x) noexcept;
+
+int64_t f$bindec(const string& number) noexcept;
+
 inline double f$ceil(double v) noexcept;
 
 inline double f$cos(double v) noexcept;
 
+string f$decbin(int64_t number) noexcept;
+
 inline double f$deg2rad(double v) noexcept;
 
+inline double f$exp(double v) noexcept;
+
 inline double f$floor(double v) noexcept;
 
+inline bool f$is_finite(double v) noexcept;
+
+inline bool f$is_infinite(double v) noexcept;
+
 inline double f$log(double v) noexcept;
 
 inline double f$log(double v, double base) noexcept;
@@ -56,8 +72,12 @@ inline double f$pi() noexcept;
 
 inline double f$round(double v, int64_t precision = 0) noexcept;
 
+inline double f$sin(double v) noexcept;
+
 inline double f$sqrt(double v) noexcept;
 
+inline double f$tan(double v) noexcept;
+
 inline mixed f$abs(const mixed& v) noexcept {
   mixed num = v.to_numeric();
   if (num.is_int()) {
@@ -86,6 +106,18 @@ inline double f$abs(const Optional<double>& v) noexcept {
   return f$abs(val(v));
 }
 
+inline double f$acos(double v) noexcept {
+  return acos(v);
+}
+
+inline double f$atan(double v) noexcept {
+  return atan(v);
+}
+
+inline double f$atan2(double y, double x) noexcept {
+  return atan2(y, x);
+}
+
 inline double f$ceil(double v) noexcept {
   return ceil(v);
 }
@@ -98,10 +130,23 @@ inline double f$deg2rad(double v) noexcept {
   return v * M_PI / 180;
 }
 
+inline double f$exp(double v) noexcept {
+  return exp(v);
+}
+
 inline double f$floor(double v) noexcept {
   return floor(v);
 }
 
+inline bool f$is_finite(double v) noexcept {
+  int v_class = std::fpclassify(v);
+  return (v_class != FP_NAN && v_class != FP_INFINITE);
+}
+
+inline bool f$is_infinite(double v) noexcept {
+  return (std::fpclassify(v) == FP_INFINITE);
+}
+
 inline double f$log(double v) noexcept {
   if (v <= 0.0) {
     return 0.0;
@@ -188,13 +233,21 @@ inline double f$round(double v, int64_t precision) noexcept {
   return round(v * mul) / mul;
 }
 
+inline double f$sin(double v) noexcept {
+  return sin(v);
+}
+
 inline double f$sqrt(double v) noexcept {
   if (v < 0) {
     return 0.0;
   }
   return sqrt(v);
 }
 
+inline double f$tan(double v) noexcept {
+  return tan(v);
+}
+
 int64_t f$hexdec(const string& number) noexcept;
 
 string f$dechex(int64_t number) noexcept;

runtime/math_functions.cpp

@@ -34,44 +34,6 @@ int64_t secure_rand_buf(char* const buf, int64_t length) noexcept {
 }
 } // namespace
 
-int64_t f$bindec(const string& number) noexcept {
-  uint64_t v = 0;
-  bool bad_str_param = number.empty();
-  bool overflow = false;
-  for (string::size_type i = 0; i < number.size(); i++) {
-    const char c = number[i];
-    if (likely(vk::any_of_equal(c, '0', '1'))) {
-      v = math_functions_impl_::mult_and_add<2>(v, static_cast<uint8_t>(c - '0'), overflow);
-    } else {
-      bad_str_param = true;
-    }
-  }
-
-  if (unlikely(bad_str_param)) {
-    php_warning("Wrong parameter '%s' in function bindec", number.c_str());
-  }
-  if (unlikely(overflow)) {
-    php_warning("Integer overflow on converting '%s' in function bindec, "
-                "the result will be different from PHP",
-                number.c_str());
-  }
-  return static_cast<int64_t>(v);
-}
-
-string f$decbin(int64_t number) noexcept {
-  auto v = static_cast<uint64_t>(number);
-
-  char s[66];
-  int i = 65;
-
-  do {
-    s[--i] = static_cast<char>((v & 1) + '0');
-    v >>= 1;
-  } while (v > 0);
-
-  return {s + i, static_cast<string::size_type>(65 - i)};
-}
-
 double f$lcg_value() {
   dl::enter_critical_section(); // OK