Fix code style

Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>

Author: PetrShumilov

runtime-light/allocator/allocator-state.h

@@ -11,7 +11,7 @@
 #include "runtime-common/core/allocator/runtime-allocator.h"
 #include "runtime-light/stdlib/diagnostics/logs.h"
 
-constexpr auto MIN_EXTRA_MEMORY_POOL_SIZE{static_cast<size_t>(64 * 1024U * 1024U)};
+inline constexpr auto DEFAULT_MIN_EXTRA_MEMORY_POOL_SIZE{static_cast<size_t>(64 * 1024U * 1024U)};
 
 class AllocatorState final : private vk::not_copyable {
   uint32_t m_libc_alloc_allowed{};

runtime-light/state/component-state.cpp

@@ -15,6 +15,7 @@
 #include <string_view>
 #include <sys/mman.h>
 #include <sys/stat.h>
+#include <system_error>
 #include <utility>
 
 #include "runtime-common/core/runtime-core.h"
@@ -31,12 +32,9 @@ std::optional<uint64_t> parse_uint64(std::string_view value_view) noexcept {
     return std::nullopt;
   }
 
-  const auto* begin{value_view.data()};
-  const auto* end{std::next(value_view.data(), value_view.size())};
-
   uint64_t res{};
-  const auto [ptr, err_code]{std::from_chars(begin, end, /* out paremeter */ res)};
-  if (err_code != std::errc{} || ptr != end) {
+  if (const auto [ptr, err_code]{std::from_chars(value_view.begin(), value_view.end(), /* out paremeter */ res)};
+      err_code != std::errc{} || ptr != value_view.end()) {
     return std::nullopt;
   }
   return res;
@@ -121,7 +119,7 @@ void ComponentState::parse_initial_instance_memory_size(std::string_view value_v
   if (!parsed) {
     kphp::log::error("couldn't parse initial instance memory size, got {}", value_view);
   }
-  initial_instance_memory_size = parsed.value();
+  initial_instance_memory_size = *parsed;
   kphp::log::info("set initial instance memory size to {} bytes", initial_instance_memory_size);
 }
 
@@ -130,7 +128,7 @@ void ComponentState::parse_min_instance_extra_memory_size(std::string_view value
   if (!parsed) {
     kphp::log::error("couldn't parse min instance extra memory size, got {}", value_view);
   }
-  min_instance_extra_memory_size = parsed.value();
+  min_instance_extra_memory_size = *parsed;
   kphp::log::info("set min instance extra memory size to {} bytes", min_instance_extra_memory_size);
 }
 
@@ -150,9 +148,9 @@ void ComponentState::parse_args() noexcept {
       parse_cluster_name_arg(value_view);
     } else if (key_view == EXIT_AFTER_RESPONSE_ARG) {
       parse_exit_after_response_arg(value_view);
-    } else if (key_view == INITIAL_INSTANCE_MEMORY_SIZE) {
+    } else if (key_view == INITIAL_INSTANCE_MEMORY_SIZE_ARG) {
       parse_initial_instance_memory_size(value_view);
-    } else if (key_view == MIN_INSTANCE_EXTRA_MEMORY_SIZE) {
+    } else if (key_view == MIN_INSTANCE_EXTRA_MEMORY_SIZE_ARG) {
       parse_min_instance_extra_memory_size(value_view);
     } else {
       kphp::log::warning("unexpected argument format: {}", key_view);

runtime-light/state/component-state.h

@@ -19,7 +19,7 @@
 #include "runtime-light/stdlib/kml/kml-state.h"
 
 struct ComponentState final : private vk::not_copyable {
-  AllocatorState component_allocator_state{INIT_COMPONENT_ALLOCATOR_SIZE, MIN_EXTRA_MEMORY_POOL_SIZE, 0};
+  AllocatorState component_allocator_state{INIT_COMPONENT_ALLOCATOR_SIZE, DEFAULT_MIN_EXTRA_MEMORY_POOL_SIZE, 0};
   KmlComponentState kml_component_state; // This member does not hold any KPHP types, so setting a reference counter is unnecessary.
 
   const uint32_t argc{k2::args_count()};
@@ -30,7 +30,7 @@ struct ComponentState final : private vk::not_copyable {
   string cluster_name{DEFAULT_CLUSTER_NAME.data(), DEFAULT_CLUSTER_NAME.size()};
   bool exit_after_response{};
   uint64_t initial_instance_memory_size{INIT_INSTANCE_ALLOCATOR_SIZE};
-  uint64_t min_instance_extra_memory_size{MIN_EXTRA_MEMORY_POOL_SIZE};
+  uint64_t min_instance_extra_memory_size{DEFAULT_MIN_EXTRA_MEMORY_POOL_SIZE};
 
   ComponentState() noexcept {
     parse_env();
@@ -61,8 +61,8 @@ struct ComponentState final : private vk::not_copyable {
   static constexpr std::string_view CLUSTER_NAME_ARG = "cluster-name";
   static constexpr std::string_view DEFAULT_CLUSTER_NAME = "default";
   static constexpr std::string_view EXIT_AFTER_RESPONSE_ARG = "exit-after-response";
-  static constexpr std::string_view INITIAL_INSTANCE_MEMORY_SIZE = "initial-instance-memory-size";
-  static constexpr std::string_view MIN_INSTANCE_EXTRA_MEMORY_SIZE = "min-instance-extra-memory-size";
+  static constexpr std::string_view INITIAL_INSTANCE_MEMORY_SIZE_ARG = "initial-instance-memory-size";
+  static constexpr std::string_view MIN_INSTANCE_EXTRA_MEMORY_SIZE_ARG = "min-instance-extra-memory-size";
   static constexpr auto INIT_COMPONENT_ALLOCATOR_SIZE = static_cast<size_t>(1024U * 1024U);      // 1MB
   static constexpr auto INIT_INSTANCE_ALLOCATOR_SIZE = static_cast<size_t>(64U * 1024U * 1024U); // 64MB
 

runtime-light/state/image-state.h

@@ -29,7 +29,7 @@
 #include "runtime-light/stdlib/visitors/shape-visitors.h"
 
 struct ImageState final : private vk::not_copyable {
-  AllocatorState image_allocator_state{INIT_IMAGE_ALLOCATOR_SIZE, MIN_EXTRA_MEMORY_POOL_SIZE, 0};
+  AllocatorState image_allocator_state{INIT_IMAGE_ALLOCATOR_SIZE, DEFAULT_MIN_EXTRA_MEMORY_POOL_SIZE, 0};
 
   uint32_t pid{k2::getpid()};
   uid_t uid{k2::getuid()};