Skip to content

Commit 2fca28b

Browse files
Deryuginalpinskiy
authored andcommitted
Simplify write_usage_metrics()
Operator &= doesn't do short circuit
1 parent e88785d commit 2fca28b

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

statshouse.hpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -342,12 +342,12 @@ class TransportUDPBase {
342342
// status "ok" is written always, error statuses only if corresponding counter != 0
343343
bool write_usage_metrics(string_view project, string_view cluster) {
344344
std::lock_guard<mutex> lo(mu);
345-
auto result = true;
346-
result = write_usage_metric_impl(project, cluster, "ok", &stats.metrics_sent , true ) && result;
347-
result = write_usage_metric_impl(project, cluster, "err_sendto_would_block", &stats.metrics_overflow, false) && result;
348-
result = write_usage_metric_impl(project, cluster, "err_sendto_other", &stats.metrics_failed , false) && result;
349-
result = write_usage_metric_impl(project, cluster, "err_odd_kv", &stats.metrics_odd_kv , false) && result;
350-
result = write_usage_metric_impl(project, cluster, "err_header_too_big", &stats.metrics_too_big , false) && result;
345+
bool result = true;
346+
result &= write_usage_metric_impl(project, cluster, "ok", &stats.metrics_sent , true );
347+
result &= write_usage_metric_impl(project, cluster, "err_sendto_would_block", &stats.metrics_overflow, false);
348+
result &= write_usage_metric_impl(project, cluster, "err_sendto_other", &stats.metrics_failed , false);
349+
result &= write_usage_metric_impl(project, cluster, "err_odd_kv", &stats.metrics_odd_kv , false);
350+
result &= write_usage_metric_impl(project, cluster, "err_header_too_big", &stats.metrics_too_big , false);
351351
return result;
352352
}
353353

0 commit comments

Comments
 (0)