fix(detectors): adjust default jitter threshold to 0.2s instead of 200s#38
Closed
vatson wants to merge 1 commit into
Closed
fix(detectors): adjust default jitter threshold to 0.2s instead of 200s#38vatson wants to merge 1 commit into
vatson wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default jitter threshold in both
InboundNetworkIssueDetectorandOutboundNetworkIssueDetectorwas set to200, which corresponds to 200 seconds. Since jitter values are reported in seconds, this default was unrealistically high and prevented correct detection of network issues.Changes
highJitterThresholdfrom200to0.2(200 ms).Why
With the previous default of 200s, jitter-related issues would never be detected in practice. Using
0.2s(200 ms) aligns with realistic network conditions and makes the detectors functional.