Skip to content

Commit 979b375

Browse files
committed
Dispose source in Remove_Middle perf test cleanup
The CleanUp lambda in Remove_Middle_ComparerIsSlowerThanNoComparer only disposed the FilteredList wrapper; the underlying ObservableList stayed alive across measurement iterations. Dispose the source too so each iteration starts from a clean state. https://claude.ai/code/session_0133w4Rt2GPd43rjC6UG5Dfg
1 parent 9f7e0c3 commit 979b375

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

Tests/Observable/Performance/FilteredListPerformanceTests.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,11 @@ public void Remove_Middle_ComparerIsSlowerThanNoComparer()
9292
for (var i = 0; i < size; i++) source.Add(i);
9393
filtered = new FilteredList<int>(source);
9494
})
95-
.CleanUp(() => filtered.Dispose())
95+
.CleanUp(() =>
96+
{
97+
filtered.Dispose();
98+
source.Dispose();
99+
})
96100
.SampleGroup(new SampleGroup("Remove_Middle_NoComparer", SampleUnit.Microsecond))
97101
.WarmupCount(WarmupCount)
98102
.MeasurementCount(MeasurementCount)
@@ -105,7 +109,11 @@ public void Remove_Middle_ComparerIsSlowerThanNoComparer()
105109
for (var i = 0; i < size; i++) source.Add(i);
106110
filtered = new FilteredList<int>(source, Comparer<int>.Default);
107111
})
108-
.CleanUp(() => filtered.Dispose())
112+
.CleanUp(() =>
113+
{
114+
filtered.Dispose();
115+
source.Dispose();
116+
})
109117
.SampleGroup(new SampleGroup("Remove_Middle_Comparer", SampleUnit.Microsecond))
110118
.WarmupCount(WarmupCount)
111119
.MeasurementCount(MeasurementCount)

0 commit comments

Comments
 (0)