#6 unused headerFields & remove logic to unshortUrl#15
Open
naushad-madakiya wants to merge 2 commits intoVRGsoftUA:masterfrom
naushad-madakiya:unshort-url-issue
Open
#6 unused headerFields & remove logic to unshortUrl#15naushad-madakiya wants to merge 2 commits intoVRGsoftUA:masterfrom naushad-madakiya:unshort-url-issue
naushad-madakiya wants to merge 2 commits intoVRGsoftUA:masterfrom
naushad-madakiya:unshort-url-issue
Conversation
added 2 commits
August 10, 2019 18:33
- Jsoup handles the redirection - remove code related to unshorten url - use content.url for actual url & content.finalUrl for final url after redirection - use empty string instead of null check when parsign meta tags Signed-off-by: Naushad Madakiya <naushad.madakiya@gmail.com>
- add short url of youtube - update UI with new section for youtube url - aligh texts to left instead of center - make title bold and url italic Signed-off-by: Naushad Madakiya <naushad.madakiya@gmail.com>
afollestad
approved these changes
Aug 16, 2019
Author
|
@pawlo2102 can someone look into the open PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unshortUrlas Jsoup does it internallycontent.urlfor original URL &content.finalUrlfor final URL after redirectionIssue: #6