Made it compile in XE2 again.

Author: vincentparrett

Src/VSoft.CommandLine.Options.pas

@@ -229,7 +229,7 @@ class function TOptionsRegistry.RegisterCommand(const name: string; const alias
 begin
   cmdDef := TCommandDefImpl.Create(name,alias, usage, description, helpString,visible);
   result := TCommandDefinition.Create(cmdDef);
-  FCommandDefs.Add(name.ToLower,cmdDef);
+  FCommandDefs.Add(LowerCase(name),cmdDef);
 end;
 
 
@@ -259,7 +259,7 @@ class procedure TOptionsRegistry.Clear;
 class function TOptionsRegistry.GetCommandByName(const name: string): ICommandDefinition;
 begin
   result := nil;
-  FCommandDefs.TryGetValue(name.ToLower,Result);
+  FCommandDefs.TryGetValue(LowerCase(name), Result);
 
 end;
 
@@ -280,7 +280,7 @@ class procedure TOptionsRegistry.EmumerateCommandOptions(const commandName: stri
 var
   cmd : ICommandDefinition;
 begin
-  if not FCommandDefs.TryGetValue(commandName.ToLower,cmd) then
+  if not FCommandDefs.TryGetValue(LowerCase(commandName), cmd) then
     raise Exception.Create('Unknown command : ' + commandName);
 
   cmd.EmumerateCommandOptions(proc);
@@ -338,7 +338,7 @@ class procedure TOptionsRegistry.PrintUsage(const command: ICommandDefinition; c
   i: Integer;
   printOption : TConstProc<IOptionDefinition>;
 begin
-  exeName := ChangeFileExt(ExtractFileName(ParamStr(0)), '').ToLower();
+  exeName := LowerCase(ChangeFileExt(ExtractFileName(ParamStr(0)), ''));
   if not command.IsDefault then
   begin
     proc('');
@@ -375,7 +375,7 @@ class procedure TOptionsRegistry.PrintUsage(const command: ICommandDefinition; c
                   begin
                     s := WrapText(opt.HelpText, sLineBreak, [' ', '-', #9, ','],  maxDescW -1);
 
-                    descStrings := s.Split([sLineBreak], TStringSplitOptions.None);
+                    descStrings := TStringUtils.Split(s, sLineBreak);
                     for i := 0 to length(descStrings) -1 do
                       descStrings[i] := Trim(descStrings[i]);
 
@@ -468,7 +468,7 @@ class procedure TOptionsRegistry.PrintUsage(const proc: TConstProc<string>; cons
   exeName : string;
 begin
   proc('');
-  exeName := ChangeFileExt(ExtractFileName(ParamStr(0)), '').ToLower();
+  exeName := LowerCase(ChangeFileExt(ExtractFileName(ParamStr(0)), ''));
 
   //if we have more than 1 command then we are using command mode
   if FCommandDefs.Count > 0 then
@@ -494,7 +494,7 @@ class procedure TOptionsRegistry.PrintUsage(const proc: TConstProc<string>; cons
         continue;
 
       s := WrapText(cmd.Description,maxDescW);
-      descStrings := s.Split([sLineBreak], TStringSplitOptions.None);
+      descStrings := TStringUtils.Split(s, sLineBreak);
       proc(' ' + PadRight(cmd.Name, descriptionTab -1) + descStrings[0]);
       numDescStrings := Length(descStrings);
       if numDescStrings > 1 then

Src/VSoft.CommandLine.Utils.pas

@@ -5,6 +5,11 @@ interface
 
 function GetConsoleWidth : integer;
 
+type
+  TStringUtils = class
+    class function Split(const theString : string; const separator : string): TArray<string>;
+  end;
+
 implementation
 
 uses
@@ -13,9 +18,51 @@ implementation
 {$ENDIF}
   System.SysUtils,
   System.StrUtils;
- 
 
+function IndexOf(const theString : string; const value : string; const startIndex : integer) : integer;
+begin
+  Result := PosEx(Value, theString, StartIndex + 1) - 1;
+end;
 
+class function TStringUtils.Split(const theString : string; const separator : string): TArray<string>;
+const
+  DeltaGrow = 32;
+var
+  NextSeparator, LastIndex: Integer;
+  Total: Integer;
+  CurrentLength: Integer;
+  S: string;
+begin
+ Total := 0;
+  LastIndex := 0;
+  CurrentLength := 0;
+  NextSeparator := IndexOf(theString, Separator, LastIndex);
+  while (NextSeparator > 0)  do
+  begin
+    S := Copy(theString, LastIndex + 1, NextSeparator - LastIndex);
+    if (S <> '') then
+    begin
+      Inc(Total);
+      if CurrentLength < Total then
+      begin
+        CurrentLength := Total + DeltaGrow;
+        SetLength(Result, CurrentLength);
+      end;
+      Result[Total - 1] := S;
+    end;
+    LastIndex := NextSeparator + Length(Separator);
+    NextSeparator := IndexOf(theString, Separator, LastIndex);
+  end;
+
+  if (LastIndex < Length(theString)) then
+  begin
+    Inc(Total);
+    SetLength(Result, Total);
+    Result[Total - 1] := Copy(theString, LastIndex + 1, Length(theString) - LastIndex);
+  end
+  else
+    SetLength(Result, Total);
+end;
 
 {$IFDEF MSWINDOWS}
 function GetConsoleWidth : integer;

Tests/TestCommandLineParser.pas

@@ -101,13 +101,16 @@   TCommandLineParserTests = class
   [Test]
   procedure Can_Parse_SpaceNameValueSeparator;
 
+  [Test]
+  procedure Test_String_Split;
 
   end;
 
 implementation
 
 uses
   Classes,
+  VSoft.CommandLine.Utils,
   VSoft.CommandLine.OptionDef;
 
 { TCommandLineParserTests }
@@ -395,6 +398,18 @@ procedure TCommandLineParserTests.Test_Single_Option;
 
 end;
 
+procedure TCommandLineParserTests.Test_String_Split;
+const
+  s : string = 'Hello' + #13#10 + 'World' + #13#10;
+var
+  values : TArray<string>;
+begin
+  values := TStringUtils.Split(s, #13#10);
+  Assert.AreEqual(2, length(values));
+  Assert.AreEqual('hello', values[0]);
+  Assert.AreEqual('world', values[1]);
+end;
+
 procedure TCommandLineParserTests.Will_Generate_Error_For_Extra_Unamed_Parameter;
 var
   def : IOptionDefinition;