chore: remove remaining legacy config wrapper and stale module refs

VaitaR · VaitaR · commit 524fc85be4e7 · 2026-02-25T12:16:11.000+03:00
diff --git a/.importlinter b/.importlinter
@@ -16,7 +16,6 @@ forbidden_modules =
     aiochainscan.services
     aiochainscan.adapters
     aiochainscan.core
-    aiochainscan.modules
     aiochainscan.scanners
 
 [importlinter:contract:2]
@@ -28,7 +27,6 @@ forbidden_modules =
     aiochainscan.services
     aiochainscan.adapters
     aiochainscan.core
-    aiochainscan.modules
     aiochainscan.scanners
 
 [importlinter:contract:3]
diff --git a/aiochainscan/config.py b/aiochainscan/config.py
@@ -711,51 +711,10 @@ def __getattr__(self, name: str) -> Any:
 config_manager = _ConfigManagerProxy()
 
 
-# Backward compatibility - expose the same interface as before
-class ChainScanConfig:
-    """Backward compatibility wrapper."""
-
-    def __init__(self) -> None:
-        pass
-
-    def get_scanner_config(self, scanner: str) -> ScannerConfig:
-        return get_config_manager().get_scanner_config(scanner)
-
-    def get_api_key(self, scanner: str) -> str | None:
-        try:
-            return get_config_manager().get_api_key(scanner)
-        except ValueError:
-            config = get_config_manager().get_scanner_config(scanner)
-            if not config.requires_api_key:
-                return ''
-            raise
-
-    def validate_network(self, scanner: str, network: str) -> str:
-        return get_config_manager().validate_network(scanner, network)
-
-    def get_supported_scanners(self) -> list[str]:
-        return get_config_manager().get_supported_scanners()
-
-    def get_scanner_networks(self, scanner: str) -> set[str]:
-        return get_config_manager().get_scanner_networks(scanner)
-
-    def create_client_config(self, scanner: str, network: str = 'main') -> dict[str, str]:
-        return get_config_manager().create_client_config(scanner, network)
-
-    def list_all_configurations(self) -> dict[str, dict[str, Any]]:
-        return get_config_manager().list_all_configurations()
-
-
-# Global instance for backward compatibility
-config = ChainScanConfig()
-
-
 # Export new advanced interface
 __all__ = [
     'ConfigurationManager',
     'ScannerConfig',
-    'ChainScanConfig',
-    'config',
     'config_manager',
     'get_config_manager',
 ]
diff --git a/aiochainscan/core/client.py b/aiochainscan/core/client.py
@@ -14,7 +14,7 @@
     from ..services.ens_resolver import ENSResolver
 
 from ..chain_registry import get_chain_info, resolve_chain_id
-from ..config import config as global_config
+from ..config import get_config_manager
 from ..constants import MAX_BLOCK_NUMBER
 from ..ports.rate_limiter import RateLimiter, RetryPolicy
 from ..scanners import get_scanner_class
@@ -34,6 +34,8 @@
 from .types import JSONDict
 from .url_builder import UrlBuilder
 
+global_config = get_config_manager()
+
 # Strict type aliases for scanner and network names (defined after imports)
 ScannerName = Literal['etherscan', 'blockscout', 'blockscout_v2']
 NetworkName = Literal[
diff --git a/docs/BUGFIX_CONNECTION_POOLING.md b/docs/BUGFIX_CONNECTION_POOLING.md
@@ -55,7 +55,7 @@
 
 ### Before (Bug - Creates 100 HTTP clients!)
 ```python
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 import asyncio
 
 addresses = ['0x...' for _ in range(100)]
@@ -133,7 +133,7 @@ $ pytest tests/ -q
 
 ### Example Warning Output
 ```python
->>> from aiochainscan import get_balance
+>>> from aiochainscan import ChainscanClient
 >>> await get_balance(address='0x...', api_kind='eth', network='main', api_key='...')
 
 DeprecationWarning: get_balance() is deprecated and will be removed in v0.5.0.
diff --git a/docs/CONNECTION_POOLING_FIX.md b/docs/CONNECTION_POOLING_FIX.md
@@ -54,7 +54,7 @@ Users believed they were getting connection pooling because:
 
 ```python
 import asyncio
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 
 addresses = ['0x...' for _ in range(100)]  # Typical whale tracking use case
 
@@ -152,7 +152,7 @@ log_batches = await asyncio.gather(*[
 ### Before (v0.3.x - Bug Present)
 
 ```python
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 import asyncio
 
 addresses = ['0x...' for _ in range(100)]
@@ -324,7 +324,7 @@ All facade functions in `aiochainscan/__init__.py`:
 ```python
 # Test that warnings are emitted
 import warnings
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 
 with warnings.catch_warnings(record=True) as w:
     warnings.simplefilter("always")
@@ -337,7 +337,7 @@ with warnings.catch_warnings(record=True) as w:
 ### Monitoring Usage
 
 Track which facade functions are still being used in the wild:
-- Check GitHub search for `from aiochainscan import get_balance`
+- Check GitHub search for `from aiochainscan import ChainscanClient`
 - Monitor PyPI download stats after v0.4.0 release
 - Provide 6-month deprecation period before v0.5.0 removal
 
diff --git a/docs/FIX_COMPLETE.md b/docs/FIX_COMPLETE.md
@@ -109,7 +109,7 @@ $ pytest tests/ -q
 $ python -c "
 import asyncio
 import warnings
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 from aiochainscan.adapters.httpx_client import HttpxClientAdapter
 
 warnings.simplefilter('always')
@@ -226,7 +226,7 @@ All documentation cross-references each other for easy navigation.
 
 **Before**:
 ```python
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 balance = await get_balance(address='0x...', api_kind='eth', network='main', api_key=key)
 ```
 
diff --git a/docs/IMPLEMENTATION_SUMMARY.md b/docs/IMPLEMENTATION_SUMMARY.md
@@ -230,7 +230,7 @@ Users have **at least one minor version** to migrate.
    - Or implement a decorator approach for consistency
 
 2. **Monitor usage**
-   - Track GitHub searches for `from aiochainscan import get_balance`
+    - Track GitHub searches for `from aiochainscan import ChainscanClient`
    - Check PyPI download stats
    - Monitor GitHub issues for migration questions
 
diff --git a/docs/MIGRATION_GUIDE.md b/docs/MIGRATION_GUIDE.md
@@ -67,7 +67,7 @@ finally:
 
 **Before (Deprecated)**:
 ```python
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 
 balance = await get_balance(
     address='0x742d35Cc6634C0532925a3b8D9fa7a3D91D1e9b3',
@@ -96,7 +96,7 @@ finally:
 
 **Before (Deprecated - Creates 100 HTTP clients!)**:
 ```python
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 import asyncio
 
 addresses = ['0x...' for _ in range(100)]
@@ -244,7 +244,7 @@ await client.close()
 The library still provides high-level facade functions that don't require creating a client:
 
 ```python
-from aiochainscan import get_address_balance, get_block_by_number
+from aiochainscan import ChainscanClient
 
 # These functions handle client creation/cleanup internally
 balance = await get_address_balance(
diff --git a/docs/QUICK_REFERENCE.md b/docs/QUICK_REFERENCE.md
@@ -15,7 +15,7 @@ DeprecationWarning: get_balance() is deprecated and will be removed in v0.5.0
 
 #### ❌ Old (Deprecated)
 ```python
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 
 balance = await get_balance(
     address='0x...',
@@ -43,7 +43,7 @@ finally:
 
 #### ❌ Old (Creates 100 HTTP clients - VERY SLOW!)
 ```python
-from aiochainscan import get_balance
+from aiochainscan import ChainscanClient
 import asyncio
 
 addresses = ['0x...' for _ in range(100)]
diff --git a/pyproject.toml b/pyproject.toml
@@ -174,19 +174,6 @@ forbidden_modules = [
   "aiochainscan.adapters",
 ]
 
-[[tool.importlinter.contracts]]
-name = "Modules do not import core/network directly or services/adapters"
-type = "forbidden"
-source_modules = [
-  "aiochainscan.modules",
-]
-forbidden_modules = [
-  "aiochainscan.services",
-  "aiochainscan.adapters",
-  "aiochainscan.core",
-  "aiochainscan.network",
-]
-
 [[tool.importlinter.contracts]]
 name = "Services do not import core or network"
 type = "forbidden"
@@ -208,29 +195,6 @@ forbidden_modules = [
   "aiochainscan.scanners",
 ]
 
-[[tool.importlinter.contracts]]
-name = "Internal packages do not import modules"
-type = "forbidden"
-source_modules = [
-  "aiochainscan.domain",
-  "aiochainscan.services",
-  "aiochainscan.adapters",
-  "aiochainscan.ports",
-]
-forbidden_modules = [
-  "aiochainscan.modules",
-]
-
-[[tool.importlinter.contracts]]
-name = "Facade does not import modules (no back-edges)"
-type = "forbidden"
-source_modules = [
-  "aiochainscan",
-]
-forbidden_modules = [
-  "aiochainscan.modules",
-]
-
 [[tool.mypy.overrides]]
 module = [
  "aiochainscan.common",
diff --git a/tests/test_e2e_balances_live.py b/tests/test_e2e_balances_live.py
@@ -25,24 +25,26 @@
 
 import pytest
 
-from aiochainscan.config import config as global_config
+from aiochainscan.config import get_config_manager
 from aiochainscan.core.client import ChainscanClient
 from aiochainscan.core.method import Method
 from aiochainscan.exceptions import ChainscanClientApiError
 
 # Well-known EOA with activity on Ethereum mainnet (may be zero elsewhere)
 TEST_ADDRESS: str = '0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045'
 
+config_manager = get_config_manager()
+
 
 def _has_api_key(scanner_id: str) -> bool:
     """Return True if API key is configured or not required."""
     try:
-        cfg = global_config.get_scanner_config(scanner_id)
+        cfg = config_manager.get_scanner_config(scanner_id)
         if not cfg.requires_api_key:
             return True
         # Attempt to resolve key via config manager (env/.env supported)
         try:
-            key = global_config.get_api_key(scanner_id)
+            key = config_manager.get_api_key(scanner_id)
             return bool(key)
         except Exception:
             return False
