Skip to content

sync#43

Merged
VaitaR merged 10 commits into
devfrom
main
Feb 25, 2026
Merged

sync#43
VaitaR merged 10 commits into
devfrom
main

Conversation

@VaitaR
Copy link
Copy Markdown
Owner

@VaitaR VaitaR commented Feb 25, 2026

No description provided.

@VaitaR VaitaR merged commit 4880663 into dev Feb 25, 2026
10 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

if abi is None and from_block == 0 and (to_block is None or to_block == 'latest'):
# Use existing simple pagination (backward compatibility)
# BlockScout V2 has special pagination with next_page_params
if self.scanner_name == 'blockscout' and self.scanner_version == 'v2':

P1 Badge Keep BlockScout V2 cursor path when decoding tx streams

The BlockScout V2 cursor-aware branch is only entered when abi is None and default block bounds are used; supplying an ABI (or non-default bounds) forces the generic page/offset path, which does not have access to BlockScout V2 next_page_params. That makes iter_transactions(..., abi=...) prone to returning only an initial subset of results for multi-page addresses, even though more pages are available.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +772 to +773
if len(batch) < batch_size:
break
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve next_page_params in transaction batch streaming

This loop treats len(batch) < batch_size as end-of-data, but for BlockScout V2 the self.call(Method.ACCOUNT_TRANSACTIONS, ...) path only returns parsed items and discards the response next_page_params cursor, so a short page does not necessarily mean completion. In environments where BlockScout V2 returns fewer than 1000 items per page while still providing a next-page cursor, iter_transactions_streaming() (and therefore get_all_transactions()) will stop early and silently truncate transaction history.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant