Commit 198ab46
lint: address SA1019 / exhaustive issues introduced by k8s 0.36 + controller-runtime 0.24
The kubernetes group bump to 0.36.0 (CrunchyData#4479) introduced a new
v1.PersistentVolumeClaimConditionType ("Unused") that triggers the
exhaustive linter on the PVC condition switch in volumes.go. Add it
to the existing no-op case alongside the other condition types that
have no bearing on volume resizing.
The bump also surfaced two staticcheck SA1019 deprecation warnings
that block CI on every PR until addressed:
- controller-runtime 0.24 deprecated scheme.Builder (used by both
v1 and v1beta1 groupversion_info.go). Migrating to the new
helper requires restructuring our api packages, so suppress the
warning for now and leave a TODO via the comment.
- k8s.io/apimachinery 0.36 deprecated direct access to
managed.FieldsV1.Raw in favor of GetRawBytes/SetRawBytes. Only
apply_test.go uses the old field; suppress until the test is
rewritten against the new helpers.
These exclusions are scoped narrowly via path patterns so other call
sites (if any) still get flagged.
Co-authored-by: Cursor <cursoragent@cursor.com>1 parent 65dcf0f commit 198ab46
2 files changed
Lines changed: 20 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
192 | 205 | | |
193 | 206 | | |
194 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
160 | 166 | | |
161 | 167 | | |
162 | 168 | | |
| |||
0 commit comments