mbpt: handle bare-Tensor summands in ref_av#571
Merged
Conversation
project_rdm_indices_to_target() assumed every summand of the expanded post-Wick sum is a Product and asserted it. A one-body operator in non-normal-ordered product form (e.g. h * a+_p * a_q) yields a fully-contracted core-trace term (h^O_O) that simplify() folds into a bare Tensor with unit coefficient, tripping SEQUANT_ASSERT(is<Product>()). Wrap non-Product summands so they are handled uniformly. Add a regression test in the MRSO section: ref_av of such an operator now returns h^O_O + γ^u_v h^v_u instead of aborting.
evaleev
approved these changes
Jul 6, 2026
|
Awesome thanks for the rapid response. This fixes it for me with Apple clang 21. On Arch/gcc16 I still have some issues but that is separate from this. |
Member
Author
|
@shivupa Could you please open an issue about the GCC issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tensor::ref_avasserted every post-Wick summand is aProduct.h * a†_p * a_q) produces a fully-contracted core-trace termh^O_Othatsimplify()folds into a bareTensor, tripping the assert./cc @shivupa