Commit 5659a35
committed
address PR #562 review: include hygiene, K_ re-init, gemm_batched congruence checks
- einsum/tiledarray.h, tile_op/batched_contract_reduce.h, pmap/slabbed_pmap.h:
include what is used (<cstdlib>, <string_view>, util/vector.h, <memory>,
<utility>) instead of relying on transitive includes
- cont_engine.h: re-initialize K_ in init_distribution_general() (defensive;
engines are single-use, but mirrors the n_slabs_ reset)
- sparse_shape.h: gemm_batched() now TA_ASSERTs that the argument ranks match
the folded gemm ranks plus the fused modes and that the fused and contracted
mode extents of the two shapes are congruent (the batched analogue of the
checks GemmHelper::compute_matrix_sizes performs for plain gemm)1 parent ef0066c commit 5659a35
5 files changed
Lines changed: 21 additions & 0 deletions
File tree
- src/TiledArray
- einsum
- expressions
- pmap
- tile_op
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
793 | 793 | | |
794 | 794 | | |
795 | 795 | | |
| 796 | + | |
796 | 797 | | |
797 | 798 | | |
798 | 799 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1719 | 1719 | | |
1720 | 1720 | | |
1721 | 1721 | | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
1722 | 1736 | | |
1723 | 1737 | | |
1724 | 1738 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
0 commit comments