Fix flaky resize debounce test#658
Merged
Merged
Conversation
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cy.setViewportStablefor resize deliveryRoot cause
The test waited two animation frames before installing the console spy, but image load, React updates, and ResizeObserver delivery can still land after that timing guess. That let the initial
onCropCompletebe counted as part of the resize burst.Validation
pnpm test📦 Published PR as canary version:
6.2.1--canary.658.13e41e0.0✨ Test out this PR locally via:
npm install react-easy-crop@6.2.1--canary.658.13e41e0.0 # or yarn add react-easy-crop@6.2.1--canary.658.13e41e0.0