Remove references to standard fix44 module

Author: davidsteiner

examples/custom-fields/Cargo.toml

@@ -7,8 +7,8 @@ license.workspace = true
 publish = false
 
 [dependencies]
-hotfix = { path = "../../crates/hotfix", features = ["fix44"] }
-hotfix-message = { path = "../../crates/hotfix-message", features = ["fix44"] }
+hotfix = { path = "../../crates/hotfix" }
+hotfix-message = { path = "../../crates/hotfix-message" }
 
 anyhow.workspace = true
 async-trait.workspace = true
@@ -19,4 +19,4 @@ tracing-subscriber = { workspace = true, features = ["env-filter"] }
 
 [build-dependencies]
 hotfix-codegen = { path = "../../crates/hotfix-codegen" }
-hotfix-dictionary = { path = "../../crates/hotfix-dictionary", features = ["fix44"] }
+hotfix-dictionary = { path = "../../crates/hotfix-dictionary" }

examples/custom-fields/README.md

@@ -24,21 +24,21 @@ addition: a `<field number="6001" name="ClientStrategyId" type="INT"/>`
 in the `<fields>` block, plus an optional reference to it on
 `NewOrderSingle` and `ExecutionReport`.
 
-## Mixing `hotfix::fix44` and `custom_fix`
+## Using the generated constants
 
-The example uses stock field constants from `hotfix::fix44::*` (e.g.
-`fix44::CL_ORD_ID`) and the new constant from `custom_fix::CLIENT_STRATEGY_ID`.
-This is safe because the custom XML didn't change any FIX 4.4 tag — the
-`custom_fix` constants for stock tags are bit-for-bit identical to the ones
-in `hotfix::fix44`. If you'd prefer a single source of truth, switch your
-imports to `custom_fix::*` everywhere.
+All field constants and typed enums (`Side`, `OrdType`, `OrdStatus`, …) come
+from the `custom_fix` module — including the ones for standard FIX 4.4
+tags. This keeps the example aligned with a single source of truth: the
+custom XML drives both compile-time typing and runtime validation. The
+`hotfix::fix44` re-exports are deliberately not used here, so the
+`hotfix` dependency in `Cargo.toml` doesn't enable the `fix44` feature.
 
 ## Running the example
 
-In one terminal, start the dummy executor:
+In one terminal, build and start the dummy executor via the existing compose file:
 
 ```shell
-cd dummy-executor && go run .
+docker compose -f example.compose.yml up --build dummy-executor
 ```
 
 In another, from the repo root, run the example:

examples/custom-fields/src/application.rs

@@ -3,9 +3,8 @@ use std::sync::Arc;
 use hotfix::Application;
 use hotfix::Message;
 use hotfix::application::{InboundDecision, OutboundDecision};
-use hotfix::fix44;
+use hotfix::message::Part;
 use hotfix::session::Status;
-use hotfix_message::Part;
 use tokio::sync::{Notify, mpsc};
 use tracing::{info, warn};
 
@@ -26,13 +25,13 @@ impl Application for TestApplication {
     }
 
     async fn on_inbound_message(&self, msg: &Message) -> InboundDecision {
-        let msg_type: Result<&str, _> = msg.header().get(hotfix_message::session_fields::MSG_TYPE);
+        let msg_type: Result<&str, _> = msg.header().get(custom_fix::MSG_TYPE);
         if !matches!(msg_type, Ok("8")) {
             return InboundDecision::Accept;
         }
 
-        let cl_ord_id: Result<&str, _> = msg.get(fix44::CL_ORD_ID);
-        let ord_status: Result<fix44::OrdStatus, _> = msg.get(fix44::ORD_STATUS);
+        let cl_ord_id: Result<&str, _> = msg.get(custom_fix::CL_ORD_ID);
+        let ord_status: Result<custom_fix::OrdStatus, _> = msg.get(custom_fix::ORD_STATUS);
         let client_strategy_id: Option<i32> = msg.get(custom_fix::CLIENT_STRATEGY_ID).ok();
 
         match (cl_ord_id, ord_status) {

examples/custom-fields/src/main.rs

@@ -9,7 +9,6 @@ use anyhow::{Context, Result, anyhow};
 use clap::Parser;
 use hotfix::config::Config;
 use hotfix::field_types::Timestamp;
-use hotfix::fix44;
 use hotfix::initiator::Initiator;
 use hotfix::store::in_memory::InMemoryMessageStore;
 use tokio::sync::{Notify, mpsc};
@@ -71,7 +70,7 @@ async fn main() -> Result<()> {
     let order = NewOrderSingle {
         cl_ord_id: CL_ORD_ID.to_string(),
         symbol: "EUR/USD".to_string(),
-        side: fix44::Side::Buy,
+        side: custom_fix::Side::Buy,
         order_qty: 100,
         transact_time: Timestamp::utc_now(),
         client_strategy_id: STRATEGY_ID,
@@ -128,7 +127,7 @@ async fn wait_for_fill(exec_rx: &mut mpsc::UnboundedReceiver<ExecReportSummary>)
             ));
         }
 
-        if matches!(summary.ord_status, fix44::OrdStatus::Filled) {
+        if matches!(summary.ord_status, custom_fix::OrdStatus::Filled) {
             info!("order filled, custom field round-tripped successfully");
             return Ok(());
         }

examples/custom-fields/src/messages.rs

@@ -1,6 +1,5 @@
 use hotfix::Message as HotfixMessage;
 use hotfix::field_types::Timestamp;
-use hotfix::fix44;
 use hotfix::message::{OutboundMessage, Part};
 
 use crate::custom_fix;
@@ -9,7 +8,7 @@ use crate::custom_fix;
 pub struct NewOrderSingle {
     pub cl_ord_id: String,
     pub symbol: String,
-    pub side: fix44::Side,
+    pub side: custom_fix::Side,
     pub order_qty: u32,
     pub transact_time: Timestamp,
     pub client_strategy_id: i32,
@@ -23,20 +22,20 @@ pub enum OutboundMsg {
 #[derive(Debug, Clone)]
 pub struct ExecReportSummary {
     pub cl_ord_id: String,
-    pub ord_status: fix44::OrdStatus,
+    pub ord_status: custom_fix::OrdStatus,
     pub client_strategy_id: Option<i32>,
 }
 
 impl OutboundMessage for OutboundMsg {
     fn write(&self, msg: &mut HotfixMessage) {
         match self {
             OutboundMsg::NewOrderSingle(order) => {
-                msg.set(fix44::CL_ORD_ID, order.cl_ord_id.as_str());
-                msg.set(fix44::SYMBOL, order.symbol.as_str());
-                msg.set(fix44::SIDE, order.side);
-                msg.set(fix44::ORDER_QTY, order.order_qty);
-                msg.set(fix44::TRANSACT_TIME, order.transact_time.clone());
-                msg.set(fix44::ORD_TYPE, fix44::OrdType::Market);
+                msg.set(custom_fix::CL_ORD_ID, order.cl_ord_id.as_str());
+                msg.set(custom_fix::SYMBOL, order.symbol.as_str());
+                msg.set(custom_fix::SIDE, order.side);
+                msg.set(custom_fix::ORDER_QTY, order.order_qty);
+                msg.set(custom_fix::TRANSACT_TIME, order.transact_time.clone());
+                msg.set(custom_fix::ORD_TYPE, custom_fix::OrdType::Market);
                 msg.set(custom_fix::CLIENT_STRATEGY_ID, order.client_strategy_id);
             }
         }