Add test case for invalid EndSeqNo in resend requests

Author: davidsteiner

crates/hotfix/tests/common/test_messages.rs

@@ -375,14 +375,23 @@ pub fn replace_field_value(raw_message: &mut Vec<u8>, tag: u32, new_value: &[u8]
 }
 
 /// Builds a resend request message without the required BeginSeqNo field.
-pub fn build_resend_request_without_begin_seq_no(msg_seq_num: u64) -> Vec<u8> {
+pub fn build_invalid_resend_request(
+    msg_seq_num: u64,
+    begin_seq_no: Option<u64>,
+    end_seq_no: Option<u64>,
+) -> Vec<u8> {
     let mut msg = Message::new("FIX.4.4", "2"); // MsgType 2 = ResendRequest
     msg.set(fix44::SENDER_COMP_ID, COUNTERPARTY_COMP_ID);
     msg.set(fix44::TARGET_COMP_ID, OUR_COMP_ID);
     msg.set(fix44::MSG_SEQ_NUM, msg_seq_num);
     msg.set(fix44::SENDING_TIME, Timestamp::utc_now());
-    // Intentionally omit BeginSeqNo (tag 7)
-    msg.set(fix44::END_SEQ_NO, 2);
+
+    if let Some(begin_seq_no) = begin_seq_no {
+        msg.set(fix44::BEGIN_SEQ_NO, begin_seq_no);
+    }
+    if let Some(end_seq_no) = end_seq_no {
+        msg.set(fix44::END_SEQ_NO, end_seq_no);
+    }
 
     msg.encode(&Config::default()).unwrap()
 }

crates/hotfix/tests/session_test_cases/resend_tests.rs

@@ -2,8 +2,7 @@ use crate::common::actions::when;
 use crate::common::assertions::{assert_msg_type, then};
 use crate::common::setup::given_an_active_session;
 use crate::common::test_messages::{
-    TestMessage, build_execution_report_with_incorrect_body_length,
-    build_resend_request_without_begin_seq_no,
+    TestMessage, build_execution_report_with_incorrect_body_length, build_invalid_resend_request,
 };
 use hotfix::message::FixMessage;
 use hotfix::session::Status;
@@ -144,24 +143,28 @@ async fn test_resent_message_previously_received_is_ignored() {
     then(&mut counterparty).gets_disconnected().await;
 }
 
-/// Tests that when a counterparty sends a resend request without the required BeginSeqNo field,
-/// the session rejects the malformed message.
+/// Tests that when a counterparty sends a resend request without the required field,
+/// the session rejects the invalid message.
 #[tokio::test]
-async fn test_resend_request_without_begin_seq_no_is_rejected() {
-    let (session, mut counterparty) = given_an_active_session().await;
-
-    // build a resend request message missing the required BeginSeqNo (tag 7)
-    let seq_num = counterparty.next_target_sequence_number();
-    let invalid_resend_request = build_resend_request_without_begin_seq_no(seq_num);
-    when(&mut counterparty)
-        .sends_raw_message(invalid_resend_request)
-        .await;
+async fn test_invalid_resend_request_gets_rejected() {
+    // We run the test twice - once with an invalid BeginSeqNo and once with an invalid EndSeqNo.
+    for (begin_seq_no, end_seq_no) in [(None, Some(2)), (Some(1), None)] {
+        let (session, mut counterparty) = given_an_active_session().await;
+
+        // build a resend request message missing the required BeginSeqNo (tag 7)
+        let seq_num = counterparty.next_target_sequence_number();
+        let invalid_resend_request =
+            build_invalid_resend_request(seq_num, begin_seq_no, end_seq_no);
+        when(&mut counterparty)
+            .sends_raw_message(invalid_resend_request)
+            .await;
 
-    // the session should reject this invalid resend request
-    then(&mut counterparty)
-        .receives(|msg| assert_msg_type(msg, MsgType::Reject))
-        .await;
+        // the session should reject this invalid resend request
+        then(&mut counterparty)
+            .receives(|msg| assert_msg_type(msg, MsgType::Reject))
+            .await;
 
-    when(&session).requests_disconnect().await;
-    then(&mut counterparty).gets_disconnected().await;
+        when(&session).requests_disconnect().await;
+        then(&mut counterparty).gets_disconnected().await;
+    }
 }