Remove unused Disconnected internal send error variant

Author: davidsteiner

crates/hotfix/src/initiator.rs

@@ -303,7 +303,7 @@ mod tests {
         }
     }
 
-    async fn given_logged_on_initiator() -> (Initiator<DummyMessage>, TestCounterparty) {
+    async fn create_logged_on_initiator() -> (Initiator<DummyMessage>, TestCounterparty) {
         let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
         let port = listener.local_addr().unwrap().port();
         let config = create_test_config("127.0.0.1", port);
@@ -438,7 +438,7 @@ mod tests {
     async fn test_session_handle_returns_working_handle() {
         use crate::session::error::SendOutcome;
 
-        let (initiator, mut counterparty) = given_logged_on_initiator().await;
+        let (initiator, mut counterparty) = create_logged_on_initiator().await;
 
         // Get the session handle and use it to send a message
         let handle = initiator.session_handle();
@@ -452,7 +452,7 @@ mod tests {
 
     #[tokio::test]
     async fn test_shutdown_with_logout_handshake() {
-        let (initiator, mut counterparty) = given_logged_on_initiator().await;
+        let (initiator, mut counterparty) = create_logged_on_initiator().await;
 
         assert!(!initiator.is_shutdown());
 

crates/hotfix/src/session/error.rs

@@ -70,12 +70,6 @@ impl From<tokio::sync::oneshot::error::RecvError> for SendError {
 /// which only make sense in the context of the public API.
 #[derive(Debug, Error)]
 pub(crate) enum InternalSendError {
-    /// The session is disconnected. Currently unused as internal sends don't
-    /// check connection state, but kept for symmetry with `SendError`.
-    #[allow(dead_code)]
-    #[error("session is disconnected")]
-    Disconnected,
-
     #[error("failed to persist message")]
     Persist(#[source] StoreError),
 
@@ -86,7 +80,6 @@ pub(crate) enum InternalSendError {
 impl From<InternalSendError> for SendError {
     fn from(err: InternalSendError) -> Self {
         match err {
-            InternalSendError::Disconnected => SendError::Disconnected,
             InternalSendError::Persist(e) => SendError::Persist(e),
             InternalSendError::SequenceNumber(e) => SendError::SequenceNumber(e),
         }
@@ -160,13 +153,6 @@ mod tests {
         assert!(matches!(err, SendError::SessionGone));
     }
 
-    #[test]
-    fn internal_send_error_disconnected_converts_to_send_error() {
-        let internal_err = InternalSendError::Disconnected;
-        let send_err: SendError = internal_err.into();
-        assert!(matches!(send_err, SendError::Disconnected));
-    }
-
     #[test]
     fn internal_send_error_persist_converts_to_send_error() {
         let internal_err = InternalSendError::Persist(test_store_error());