Drop config path as CLI arg

Author: davidsteiner

Cargo.lock

@@ -12,7 +12,6 @@ hotfix-message = { path = "../../crates/hotfix-message" }
 
 anyhow.workspace = true
 async-trait.workspace = true
-clap = { workspace = true, features = ["derive"] }
 tokio = { workspace = true, features = ["full"] }
 tracing.workspace = true
 tracing-subscriber = { workspace = true, features = ["env-filter"] }

examples/custom-fields/Cargo.toml

@@ -44,7 +44,7 @@ docker compose -f example.compose.yml up --build dummy-executor
 In another, from the repo root, run the example:
 
 ```shell
-cargo run -p custom-fields -- --config examples/custom-fields/config/test-config.toml
+cargo run -p custom-fields
 ```
 
 Expected log output:

examples/custom-fields/README.md

@@ -6,7 +6,6 @@ use std::sync::Arc;
 use std::time::Duration;
 
 use anyhow::{Context, Result, anyhow};
-use clap::Parser;
 use hotfix::config::Config;
 use hotfix::field_types::Timestamp;
 use hotfix::initiator::Initiator;
@@ -19,28 +18,21 @@ use tracing_subscriber::EnvFilter;
 use crate::application::TestApplication;
 use crate::messages::{ExecReportSummary, NewOrderSingle, OutboundMsg};
 
+const CONFIG_PATH: &str = "examples/custom-fields/config/test-config.toml";
 const LOGON_TIMEOUT: Duration = Duration::from_secs(10);
 const FILL_TIMEOUT: Duration = Duration::from_secs(10);
 const STRATEGY_ID: i32 = 42;
 const CL_ORD_ID: &str = "demo-1";
 
-#[derive(Parser, Debug)]
-#[command(author, version, about)]
-struct Args {
-    #[arg(short, long)]
-    config: String,
-}
-
 #[tokio::main]
 async fn main() -> Result<()> {
-    let args = Args::parse();
-
     tracing_subscriber::fmt()
-        .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| EnvFilter::new("info")))
+        .with_env_filter(
+            EnvFilter::try_from_default_env().unwrap_or_else(|_| EnvFilter::new("info")),
+        )
         .init();
 
-    let mut config = Config::load_from_path(&args.config)
-        .context("failed to load config")?;
+    let mut config = Config::load_from_path(CONFIG_PATH).context("failed to load config")?;
     let session_config = config
         .sessions
         .pop()
@@ -54,13 +46,10 @@ async fn main() -> Result<()> {
         exec_tx,
     };
 
-    let initiator: Initiator<OutboundMsg> = Initiator::start(
-        session_config,
-        app,
-        InMemoryMessageStore::default(),
-    )
-    .await
-    .context("failed to start initiator")?;
+    let initiator: Initiator<OutboundMsg> =
+        Initiator::start(session_config, app, InMemoryMessageStore::default())
+            .await
+            .context("failed to start initiator")?;
 
     info!("waiting for logon (up to {:?})", LOGON_TIMEOUT);
     timeout(LOGON_TIMEOUT, logon_signal.notified())
@@ -75,9 +64,7 @@ async fn main() -> Result<()> {
         transact_time: Timestamp::utc_now(),
         client_strategy_id: STRATEGY_ID,
     };
-    info!(
-        "sending NewOrderSingle ClOrdID={CL_ORD_ID} ClientStrategyId={STRATEGY_ID}"
-    );
+    info!("sending NewOrderSingle ClOrdID={CL_ORD_ID} ClientStrategyId={STRATEGY_ID}");
     initiator
         .send(OutboundMsg::NewOrderSingle(order))
         .await
@@ -99,27 +86,33 @@ async fn wait_for_fill(exec_rx: &mut mpsc::UnboundedReceiver<ExecReportSummary>)
     loop {
         let remaining = deadline.saturating_duration_since(tokio::time::Instant::now());
         if remaining.is_zero() {
-            return Err(anyhow!("did not receive a Filled ExecutionReport within {FILL_TIMEOUT:?}"));
+            return Err(anyhow!(
+                "did not receive a Filled ExecutionReport within {FILL_TIMEOUT:?}"
+            ));
         }
 
         let summary = match timeout(remaining, exec_rx.recv()).await {
             Ok(Some(s)) => s,
             Ok(None) => return Err(anyhow!("execution-report channel closed unexpectedly")),
-            Err(_) => return Err(anyhow!("did not receive a Filled ExecutionReport within {FILL_TIMEOUT:?}")),
+            Err(_) => {
+                return Err(anyhow!(
+                    "did not receive a Filled ExecutionReport within {FILL_TIMEOUT:?}"
+                ));
+            }
         };
 
         info!(
             "received ExecutionReport ClOrdID={} OrdStatus={:?} ClientStrategyId={:?}",
             summary.cl_ord_id, summary.ord_status, summary.client_strategy_id,
         );
 
-        let echoed = summary
-            .client_strategy_id
-            .ok_or_else(|| anyhow!(
+        let echoed = summary.client_strategy_id.ok_or_else(|| {
+            anyhow!(
                 "ExecutionReport for ClOrdID={} did not echo ClientStrategyId — \
                  the acceptor likely doesn't know about tag 6001",
                 summary.cl_ord_id,
-            ))?;
+            )
+        })?;
 
         if echoed != STRATEGY_ID {
             return Err(anyhow!(