Skip to content

Commit fc903fe

Browse files
committed
Clean up warnings in session code
1 parent a6b061e commit fc903fe

1 file changed

Lines changed: 8 additions & 14 deletions

File tree

crates/hotfix/src/session.rs

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -429,13 +429,10 @@ impl<M: FixMessage, S: MessageStore> Session<M, S> {
429429
}
430430

431431
async fn on_test_request(&mut self, message: &Message) {
432-
let req_id: &str = match message.get(fix44::TEST_REQ_ID) {
433-
Ok(val) => val,
434-
Err(_) => {
435-
// TODO: send reject?
436-
todo!()
437-
}
438-
};
432+
let req_id: &str = message.get(fix44::TEST_REQ_ID).unwrap_or_else(|_| {
433+
// TODO: send reject?
434+
todo!()
435+
});
439436

440437
self.send_message(Heartbeat::for_request(req_id.to_string()))
441438
.await;
@@ -444,13 +441,10 @@ impl<M: FixMessage, S: MessageStore> Session<M, S> {
444441
async fn on_resend_request(&mut self, message: &Message) {
445442
// TODO: verify message and send reject as necessary
446443

447-
let begin_seq_number: usize = match message.get(fix44::BEGIN_SEQ_NO) {
448-
Ok(seq_number) => seq_number,
449-
Err(_) => {
450-
// TODO: send reject if there is no valid begin number
451-
todo!()
452-
}
453-
};
444+
let begin_seq_number: usize = message.get(fix44::BEGIN_SEQ_NO).unwrap_or_else(|_| {
445+
// TODO: send reject if there is no valid begin number
446+
todo!()
447+
});
454448

455449
let end_seq_number: usize = match message.get(fix44::END_SEQ_NO) {
456450
Ok(seq_number) => {

0 commit comments

Comments
 (0)