Skip to content

Parse messages in session tests so assertions can be made on their details#131

Merged
davidsteiner merged 1 commit into
mainfrom
93-parse-messages-from-mock-cpty
Jul 28, 2025
Merged

Parse messages in session tests so assertions can be made on their details#131
davidsteiner merged 1 commit into
mainfrom
93-parse-messages-from-mock-cpty

Conversation

@davidsteiner

@davidsteiner davidsteiner commented Jul 28, 2025

Copy link
Copy Markdown
Member

It also removes the separate spawned task for messages received from the session and consumes messages directly from the channel connecting the mock counterparty to the session.

@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.08%. Comparing base (6e7ea11) to head (91335ae).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/hotfix/tests/common/mock_counterparty.rs 84.61% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   59.95%   60.08%   +0.12%     
==========================================
  Files          66       66              
  Lines        2712     2723      +11     
==========================================
+ Hits         1626     1636      +10     
- Misses       1086     1087       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidsteiner davidsteiner requested a review from DGPardo July 28, 2025 07:42
@davidsteiner davidsteiner linked an issue Jul 28, 2025 that may be closed by this pull request
@davidsteiner davidsteiner merged commit 11d327c into main Jul 28, 2025
4 checks passed
@davidsteiner davidsteiner deleted the 93-parse-messages-from-mock-cpty branch July 28, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build test framework for session layer

2 participants