Allow the heartbeat timer to be disabled by setting it to None#132
Merged
davidsteiner merged 1 commit intoJul 29, 2025
Merged
Conversation
davidsteiner
commented
Jul 28, 2025
davidsteiner
commented
Jul 28, 2025
davidsteiner
commented
Jul 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 60.04% 62.31% +2.26%
==========================================
Files 66 66
Lines 2723 2749 +26
==========================================
+ Hits 1635 1713 +78
+ Misses 1088 1036 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DGPardo
reviewed
Jul 28, 2025
DGPardo
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than pushing out the duration to a large amount, make the heartbeat timer an
Optionso we can just disable it by setting it toNone