Skip to content

Allow the heartbeat timer to be disabled by setting it to None#132

Merged
davidsteiner merged 1 commit into
mainfrom
109-avoid-heartbeats-when-there-is-no-established-session
Jul 29, 2025
Merged

Allow the heartbeat timer to be disabled by setting it to None#132
davidsteiner merged 1 commit into
mainfrom
109-avoid-heartbeats-when-there-is-no-established-session

Conversation

@davidsteiner

Copy link
Copy Markdown
Member

Rather than pushing out the duration to a large amount, make the heartbeat timer an Option so we can just disable it by setting it to None

@davidsteiner davidsteiner linked an issue Jul 28, 2025 that may be closed by this pull request
Comment thread crates/hotfix/tests/session_tests.rs
Comment thread crates/hotfix/tests/common/mock_counterparty.rs
Comment thread crates/hotfix/src/session.rs
@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.31%. Comparing base (11d327c) to head (da41f56).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/hotfix/src/session.rs 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   60.04%   62.31%   +2.26%     
==========================================
  Files          66       66              
  Lines        2723     2749      +26     
==========================================
+ Hits         1635     1713      +78     
+ Misses       1088     1036      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidsteiner davidsteiner requested a review from DGPardo July 28, 2025 13:16
Comment thread crates/hotfix/tests/session_tests.rs
Comment thread crates/hotfix/src/session.rs
@davidsteiner davidsteiner merged commit a3b1d61 into main Jul 29, 2025
4 checks passed
@davidsteiner davidsteiner deleted the 109-avoid-heartbeats-when-there-is-no-established-session branch July 29, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid heartbeats when there is no established session

2 participants