Skip to content

Avoid peer timeout checks when there is no established connection#134

Merged
davidsteiner merged 5 commits into
mainfrom
110-avoid-peer-timeout-checks-when-there-is-no-established-session
Aug 5, 2025
Merged

Avoid peer timeout checks when there is no established connection#134
davidsteiner merged 5 commits into
mainfrom
110-avoid-peer-timeout-checks-when-there-is-no-established-session

Conversation

@davidsteiner

Copy link
Copy Markdown
Member
  • Changes the design so that we only store tokio Instants rather than pinned timer futures to simplify ownership logic
  • Moves the peer timer into the active state to ensure it can only tick at appropriate times
  • Moves the expected request ID for sent test requests into the active state

@davidsteiner davidsteiner linked an issue Aug 1, 2025 that may be closed by this pull request
@codecov

codecov Bot commented Aug 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.56%. Comparing base (6a6f7e3) to head (80306fe).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/hotfix/src/session.rs 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   62.39%   63.56%   +1.17%     
==========================================
  Files          66       66              
  Lines        2760     2775      +15     
==========================================
+ Hits         1722     1764      +42     
+ Misses       1038     1011      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidsteiner davidsteiner requested a review from DGPardo August 1, 2025 11:51

@DGPardo DGPardo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@davidsteiner davidsteiner merged commit 202c400 into main Aug 5, 2025
4 checks passed
@davidsteiner davidsteiner deleted the 110-avoid-peer-timeout-checks-when-there-is-no-established-session branch August 5, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid peer timeout checks when there is no established session

2 participants