fix(i18n): add 6 missing Japanese translation keys#864
Conversation
Add 6 missing Japanese (ja) translation keys that exist in en, zh, and ru but were absent from the Japanese locale files: cron.json: - dialog.channelUnsupportedTag - dialog.deliveryChannelUnsupported - toast.deliveryChannelUnsupported settings.json: - aiProviders.oauth.getApiKey - advanced.telemetry - advanced.telemetryDesc
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fa0d628e7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "slug": "mmx-cli", | ||
| "repo": "MiniMax-AI/cli", | ||
| "repoPath": "skill", | ||
| "ref": "main", | ||
| "version": "main", |
There was a problem hiding this comment.
This patch is scoped to Japanese locale keys, but it also adds a new mmx-cli entry to the preinstalled skills manifest, which changes product behavior by bundling and deploying another third-party skill for users. Because preinstalled skills are installed on startup and can be auto-enabled (ensurePreinstalledSkillsInstalled in electron/utils/skill-config.ts), this introduces an unrelated runtime change in a localization fix and should be split out (or reverted) to avoid shipping unexpected functionality.
Useful? React with 👍 / 👎.
1 participant
Problem
The Japanese (ja) locale files were missing 6 translation keys that exist in English, Chinese (zh), and Russian (ru). These missing keys would cause the app to fall back to the English strings when running in Japanese.
Missing from
src/i18n/locales/ja/cron.json:dialog.channelUnsupportedTag— badge shown when a channel doesn't support scheduled deliverydialog.deliveryChannelUnsupported— message shown in the delivery channel selectortoast.deliveryChannelUnsupported— toast notification when an unsupported channel is selectedMissing from
src/i18n/locales/ja/settings.json:aiProviders.oauth.getApiKey— "Get API Key" button label in OAuth provider cardadvanced.telemetry— label for the anonymous usage data toggleadvanced.telemetryDesc— description for the telemetry toggleSolution
Added the missing Japanese translations matching the meaning of the existing en/zh/ru translations:
cron:dialog.channelUnsupportedTagcron:dialog.deliveryChannelUnsupportedcron:toast.deliveryChannelUnsupportedsettings:aiProviders.oauth.getApiKeysettings:advanced.telemetrysettings:advanced.telemetryDescTesting
python3 -m json.tool)pnpm exec tsc -p tsconfig.json --noEmit)