Cleanup

Author: xPaw

web/src/components/Docs/ReferencedBy.tsx

@@ -86,7 +86,7 @@ export function ReferencedBy({ name, module }: { name: string; module: string })
           </RefLink>
         ))}
         {collapsible && (
-          <ToggleButton onClick={() => setExpanded(!expanded)}>
+          <ToggleButton onClick={() => setExpanded(!expanded)} aria-label={expanded ? "Show fewer references" : "Show all references"} aria-expanded={expanded}>
             {expanded ? "show less" : `+${refs.length - COLLAPSE_THRESHOLD} more…`}
           </ToggleButton>
         )}

web/src/components/Docs/SchemaClass.tsx

@@ -1,5 +1,5 @@
 import React, { useContext, useMemo } from "react";
-import { Link, useNavigate } from "react-router-dom";
+import { useNavigate } from "react-router-dom";
 import styled from "styled-components";
 import * as api from "./api";
 import { SchemaTypeView, MetadataTags } from "./SchemaType";
@@ -8,6 +8,7 @@ import { KindIcon } from "./utils/components";
 import { DeclarationsContext } from "./DeclarationsContext";
 import { useSearchWords, useSearchOffsets } from "./utils/filtering";
 import {
+  CollapsedItemsLink,
   CommonGroupMembers,
   CommonGroupSignature,
   CommonGroupWrapper,
@@ -58,17 +59,6 @@ const FieldOffset = styled.span`
   }
 `;
 
-const CollapsedFieldsLink = styled(Link)`
-  display: block;
-  padding: 4px 8px;
-  font-size: 14px;
-  color: ${(props) => props.theme.textDim};
-  text-decoration: none;
-
-  &:hover {
-    text-decoration: underline;
-  }
-`;
 
 export const ModuleBadge: React.FC<{ module: string }> = ({ module }) => {
   const { root } = useContext(DeclarationsContext);
@@ -151,9 +141,9 @@ export const SchemaClassView: React.FC<{
           <SchemaFieldView key={field.name} field={field} highlighted={(searchWords.length > 0 && matchesWords(field.name, searchWords)) || (searchOffsets.length > 0 && searchOffsets.includes(field.offset))} />
         ))}
         {hiddenCount > 0 && (
-          <CollapsedFieldsLink to={`${root}/${declaration.module}/${declaration.name}`}>
+          <CollapsedItemsLink to={`${root}/${declaration.module}/${declaration.name}`}>
             {hiddenCount} more field{hiddenCount !== 1 ? "s" : ""}…
-          </CollapsedFieldsLink>
+          </CollapsedItemsLink>
         )}
       </ClassMembers>
     )}

web/src/components/Docs/SchemaEnum.tsx

@@ -1,6 +1,5 @@
 import * as api from "./api";
 import React, { useContext, useMemo } from "react";
-import { Link } from "react-router-dom";
 import styled from "styled-components";
 import { ColoredSyntax } from "~components/ColoredSyntax";
 import { KindIcon } from "./utils/components";
@@ -10,6 +9,7 @@ import { ReferencedBy } from "./ReferencedBy";
 import { ModuleBadge, matchesWords } from "./SchemaClass";
 import { useSearchWords } from "./utils/filtering";
 import {
+  CollapsedItemsLink,
   CommonGroupMembers,
   CommonGroupSignature,
   CommonGroupWrapper,
@@ -48,17 +48,6 @@ const EnumMemberSignature = styled.div`
   font-size: 16px;
 `;
 
-const CollapsedMembersLink = styled(Link)`
-  display: block;
-  padding: 4px 8px;
-  font-size: 14px;
-  color: ${(props) => props.theme.textDim};
-  text-decoration: none;
-
-  &:hover {
-    text-decoration: underline;
-  }
-`;
 
 export const SchemaEnumView: React.FC<{
   className?: string;
@@ -96,9 +85,9 @@ export const SchemaEnumView: React.FC<{
           <EnumMemberView key={member.name} member={member} highlighted={searchWords.length > 0 && matchesWords(member.name, searchWords)} />
         ))}
         {hiddenCount > 0 && (
-          <CollapsedMembersLink to={`${root}/${declaration.module}/${declaration.name}`}>
+          <CollapsedItemsLink to={`${root}/${declaration.module}/${declaration.name}`}>
             {hiddenCount} more member{hiddenCount !== 1 ? "s" : ""}…
-          </CollapsedMembersLink>
+          </CollapsedItemsLink>
         )}
       </EnumMembers>
     )}

web/src/components/Docs/utils/styles.tsx

@@ -48,3 +48,15 @@ export const DeclarationNameLink = styled(Link)`
     text-decoration: underline;
   }
 `;
+
+export const CollapsedItemsLink = styled(Link)`
+  display: block;
+  padding: 4px 8px;
+  font-size: 14px;
+  color: ${(props) => props.theme.textDim};
+  text-decoration: none;
+
+  &:hover {
+    text-decoration: underline;
+  }
+`;

web/src/components/Search/index.tsx

@@ -60,6 +60,8 @@ export function SearchBox({ baseUrl, className, placeholder = "Search..." }: { b
       setInputValue(urlSearch);
       pendingRef.current = urlSearch;
     }
+  // Intentionally depends only on location.search — we sync *from* the URL,
+  // not when search/setSearch change (which would cause loops).
   }, [location.search]); // eslint-disable-line react-hooks/exhaustive-deps
 
   // Sync input when search is set externally (e.g. from programmatic navigation)

web/src/components/Search/search.svg

@@ -11,6 +11,7 @@ export async function loadSchemas(): Promise<Declaration[]> {
   if (cached) return cached;
 
   const response = await fetch(`${import.meta.env.BASE_URL}schemas.json`);
+  if (!response.ok) throw new Error(`Failed to load schemas: ${response.status}`);
   const data: SchemasJson = await response.json();
 
   const classes: Declaration[] = data.classes.map((c) => ({ ...c, kind: "class" as const }));

web/src/pages/data.ts

@@ -18,7 +18,7 @@ export default function SchemasPage() {
   useEffect(() => {
     loadSchemas()
       .then(setDeclarations)
-      .catch((e) => setError(String(e)));
+      .catch((e) => setError(e instanceof Error ? e.message : String(e)));
   }, []);
 
   if (error) return <><NavBar /><LoadingMessage>Failed to load schemas: {error}</LoadingMessage></>;