Remove Lookup support

Author: xPaw

ValveKeyValue/ValveKeyValue.Test/Text/LookupTestCase.cs

@@ -19,19 +19,14 @@ public static object MakeObject(
             [DynamicallyAccessedMembers(Trimming.Properties)] Type objectType, KVObject keyValueObject, IObjectReflector reflector)
             => InvokeGeneric(nameof(MakeObject), objectType, new object[] { keyValueObject, reflector });
 
-        [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2062", Justification = "If the lookup value type exists at runtime then it should have enough for us to introspect.")]
         public static TObject MakeObject<[DynamicallyAccessedMembers(Trimming.Constructors | Trimming.Properties)] TObject>(KVObject keyValueObject, IObjectReflector reflector)
         {
             ArgumentNullException.ThrowIfNull(keyValueObject);
             ArgumentNullException.ThrowIfNull(reflector);
 
             if (keyValueObject.ValueType == KVValueType.Collection)
             {
-                if (IsLookupWithStringKey(typeof(TObject), out var lookupValueType))
-                {
-                    return (TObject)MakeLookup(lookupValueType, keyValueObject, reflector);
-                }
-                else if (IsDictionary(typeof(TObject)))
+                if (IsDictionary(typeof(TObject)))
                 {
                     return (TObject)MakeDictionary(typeof(TObject), keyValueObject, reflector);
                 }
@@ -182,47 +177,6 @@ static bool IsArray(KVObject obj, out object[] values)
             return true;
         }
 
-        static bool IsLookupWithStringKey(Type type, out Type valueType)
-        {
-            valueType = null;
-
-            if (!type.IsConstructedGenericType)
-            {
-                return false;
-            }
-
-            var genericType = type.GetGenericTypeDefinition();
-            if (genericType != typeof(ILookup<,>))
-            {
-                return false;
-            }
-
-            var genericArguments = type.GetGenericArguments();
-            if (genericArguments.Length != 2)
-            {
-                return false;
-            }
-
-            if (genericArguments[0] != typeof(string))
-            {
-                return false;
-            }
-
-            valueType = genericArguments[1];
-            return true;
-        }
-
-        static object MakeLookup(
-            [DynamicallyAccessedMembers(Trimming.Constructors | Trimming.Properties)] Type valueType,
-            KVObject obj,
-            IObjectReflector reflector)
-            => InvokeGeneric(nameof(MakeLookupCore), valueType, new object[] { obj, reflector });
-
-        static ILookup<string, TValue> MakeLookupCore<[DynamicallyAccessedMembers(Trimming.Constructors | Trimming.Properties)] TValue>(KVObject obj, IObjectReflector reflector)
-        {
-            return obj.ToLookup(kvp => kvp.Key, kvp => ConvertValue<TValue>(kvp.Value, reflector));
-        }
-
         static readonly Dictionary<Type, Func<Type, object[], IObjectReflector, object>> EnumerableBuilders = new()
         {
             [typeof(List<>)] = (type, values, reflector) => InvokeGeneric(nameof(MakeList), type.GetGenericArguments()[0], new object[] { values, reflector }),