Make the underlying type and value readonly

Author: xPaw

ValveKeyValue/ValveKeyValue/KVDocument.cs

@@ -22,15 +22,10 @@ public class KVDocument : KVObject
         /// <param name="name">Root key name of the document.</param>
         /// <param name="root">Root value of the document.</param>
         public KVDocument(KVHeader header, string name, KVObject root)
+            : base(root.ValueType, root._scalar, root._ref, root.Flag)
         {
             Header = header;
             Name = name;
-
-            // Copy the root's fields into this document object
-            ValueType = root.ValueType;
-            Flag = root.Flag;
-            _scalar = root._scalar;
-            _ref = root._ref;
         }
     }
 }

ValveKeyValue/ValveKeyValue/KVObject.cs

@@ -18,7 +18,7 @@ public partial class KVObject : IEnumerable<KeyValuePair<string, KVObject>>
         /// <summary>
         /// Gets the value type of this object.
         /// </summary>
-        public KVValueType ValueType { get; internal set; }
+        public KVValueType ValueType { get; }
 
         /// <summary>
         /// Gets or sets the flags of this object.
@@ -27,10 +27,10 @@ public partial class KVObject : IEnumerable<KeyValuePair<string, KVObject>>
 
         // Inline storage for scalar types (no boxing).
         // Interpretation depends on ValueType.
-        internal long _scalar;
+        internal readonly long _scalar;
 
         // Reference storage for heap types: string, byte[], List<KVObject>, Dictionary<string, KVObject>, etc.
-        internal object _ref;
+        internal readonly object _ref;
 
         /// <summary>
         /// Gets a value indicating whether this value is null.