Don't use assert() in tests

zpostfacto · zpostfacto · commit 092ec40cfb7f · 2026-04-25T13:15:41.000-07:00
It pops a dialog on windows and hangs
diff --git a/tests/test_common.cpp b/tests/test_common.cpp
@@ -53,7 +53,13 @@ static void DebugOutput( ESteamNetworkingSocketsDebugOutputType eType, const cha
 		if ( strstr( pszMsg, "SteamNetworkingGlobalLock held for" ) )
 			return;
 
-		assert( !"TEST FAILED" );
+		fprintf( stderr, "\n\n"
+			"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n"
+			"!!                     TEST FAILED                          !!\n"
+			"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n"
+			"\n", pszMsg );
+		fflush( stderr );
+		abort();
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,13 @@ static void DebugOutput( ESteamNetworkingSocketsDebugOutputType eType, const cha`
`53`	`53`	`if ( strstr( pszMsg, "SteamNetworkingGlobalLock held for" ) )`
`54`	`54`	`return;`
`55`	`55`
`56`		`- assert( !"TEST FAILED" );`
	`56`	`+ fprintf( stderr, "\n\n"`
	`57`	`+ "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n"`
	`58`	`+ "!! TEST FAILED !!\n"`
	`59`	`+ "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n"`
	`60`	`+ "\n", pszMsg );`
	`61`	`+ fflush( stderr );`
	`62`	`+ abort();`
`57`	`63`	`}`
`58`	`64`	`}`
`59`	`65`